OpenPKG CVS Repository http://cvs.openpkg.org/ ____________________________________________________________________________
Server: cvs.openpkg.org Name: Ralf S. Engelschall Root: /e/openpkg/cvs Email: [EMAIL PROTECTED] Module: openpkg-re Date: 21-Jul-2003 14:18:10 Branch: HEAD Handle: 2003072113181000 Modified files: openpkg-re speclint.pl Log: start complaining about hard-coded %{l_prefix} in %{pre,post,preun,postun} sections from now on Summary: Revision Changes Path 1.40 +11 -0 openpkg-re/speclint.pl ____________________________________________________________________________ patch -p0 <<'@@ .' Index: openpkg-re/speclint.pl ============================================================================ $ cvs diff -u -r1.39 -r1.40 speclint.pl --- openpkg-re/speclint.pl 21 Jul 2003 11:54:11 -0000 1.39 +++ openpkg-re/speclint.pl 21 Jul 2003 12:18:10 -0000 1.40 @@ -814,6 +814,17 @@ } } + # check for hard-coded prefix in %pre[un],%post[un] scripts + if ($section =~ m/^\%(preun|postun|pre|post)$/s and $file !~ m|openpkg\.spec$|) { + $done = $outer_done; $this = ''; $todo = $outer_this; + while ($todo =~ m/\%\{l_prefix\}/s) { + $done .= $`; $this = $&; $todo = $'; + &lint_warning($file, $done, $this, "section $section: hard-coded prefix (\%{l_prefix}) found " . + "(use \"\$RPM_INSTALL_PREFIX\" to allow relocation)"); + $done .= $this; + } + } + # TODO: parenthesis style for sub-shells } @@ . ______________________________________________________________________ The OpenPKG Project www.openpkg.org CVS Repository Commit List [EMAIL PROTECTED]