On Wed, Apr 14, 2004, OpenPKG Project Robot wrote:

> The following OpenPKG Contribution Area operation occurred.
> uploaded DIFF file "pureftpd.spec.diff" accepted -- moved to contrib area.
> No action is required on your part.
> [...]

| This is an enhanced version of PureFTPD supporting different
| kinds of user authentication.
|
| It implements additional options for user authentication against
|    ldap directory services
|    mysql database
|    puredb database (fast and small for virtual users)
|
| There are two bugfixes for Solaris 9 platform:
|    autodetecting libraries for ldap doesn't work
|    configure test leaves an unremovable directory behind
|
| Birger Kraegelin, Fraunhofer NOC
| [EMAIL PROTECTED]
| ################################################################
| --- pureftpd.spec.orig        Tue Apr 13 10:24:49 2004
| +++ pureftpd.spec     Tue Apr 13 12:30:42 2004
| @@ -34,11 +34,14 @@
|  Group:        FTP
|  License:      GPL
|  Version:      1.0.17a
| -Release:      2.0.0
| +Release:      2.0.0noc
|
|  #   package options
| -%option       with_fsl  yes
| -%option       with_pam  no
| +%option       with_fsl     yes
| +%option       with_pam     no
| +%option       with_ldap    no
| +%option       with_mysql   no
| +%option       with_puredb  no
|
|  #   list of sources
|  Source0:      
ftp://ftp.pureftpd.org/pub/pure-ftpd/releases/pure-ftpd-%{version}.tar.gz
| @@ -58,6 +61,14 @@
|  BuildPreReq:  PAM
|  PreReq:       PAM
|  %endif
| +%if "%{with_ldap}" == "yes"
| +BuildPreReq:  openldap, openssl
| +PreReq:       openldap, openssl
| +%endif
| +%if "%{with_mysql}" == "yes"
| +BuildPreReq:  mysql
| +PreReq:       mysql
| +%endif
|  AutoReq:      no
|  AutoReqProv:  no
|
| @@ -91,6 +102,9 @@
|      CPPFLAGS="-I`%{l_prefix}/etc/rc --query pam_incdir`" \
|      LDFLAGS="-L`%{l_prefix}/etc/rc --query pam_libdir` ${LDFLAGS}" \
|  %endif
| +%if "%{with_ldap}" == "yes"
| +    LIBS="${LIBS} -lldap -lssl -lcrypto -llber" \
| +%endif
|      ./configure \
|          --prefix=%{l_prefix} \
|          --sysconfdir=%{l_prefix}/etc/pureftpd \
| @@ -101,9 +115,25 @@
|  %if "%{with_pam}" == "yes"
|          --with-pam \
|  %endif
| +%if "%{with_ldap}" == "yes"
| +        --with-ldap=%{l_prefix} \
| +%endif
| +%if "%{with_mysql}" == "yes"
| +        --with-mysql=%{l_prefix} \
| +%endif

If we support MySQL, we also should support PostgreSQL (sorry, I'm a
MySQL basher and PostgreSQL fan :-) I'll add a "with_pgsql" option here,
too.

| +%if "%{with_puredb}" == "yes"
| +        --with-puredb \
| +%endif
| +%if "%{with_extauth}" == "yes"
| +        --with-extauth \
| +%endif

This is a no-op, because there is no %option for "with_extauth".
Instead I think it is more reasonable to provide "with_minimal" and
"with_everything" options which use --with-minimal and --with-everything
because --with-everything includes --with-puredb and --with-extauth plus
lots of more. And either we should provide options for all existing and
reasonable features or it is better to use the bundle options only.

|          --with-ftpwho \
|          --with-virtualhosts \
|          --with-language=english
| +    #   fix a bug in configure:
| +    #      checking whether realpath likes unreadable directories
| +    #      leaves a directory, which is not removable
| +    chmod +w x

This breaks for me under at least FreeBSD, because there
a "x" directory is _not_ left.

|      %{l_make} %{l_mflags -O}
|
|  %install

Look at http://cvs.openpkg.org/chngview?cn=15885 for the change I've now
comitted to CVS for OpenPKG-CURRENT. I think it is a superset of your
changes and allows you to solve your local problem by using this CURRENT
package 1:1 with your 2.0 instance. Alternatively you have to maintain
your patch locally until 2.1 is out. For this expect support soon (we've
already worked off the "openpkg dev" shell the last days and now I'm
implementing an "openpkg vendor" tool plus a HOWTO describing how to use
this stuff in a full-features contributor environment like yours).

                                       Ralf S. Engelschall
                                       [EMAIL PROTECTED]
                                       www.engelschall.com

______________________________________________________________________
The OpenPKG Project                                    www.openpkg.org
Developer Communication List                   [EMAIL PROTECTED]

Reply via email to