Summary: amf: Resequence logs during si-swap of safSi=SC-2N,safApp=OpenSAF [#513] Review request for Trac Ticket(s): #513 Peer Reviewer(s): Praveen, Mathi Pull request to: Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 512202f066c53bb9bbca1e00b2d9f1d3754296a2 Author: Nagendra Kumar<[email protected]> Date: Mon, 22 Jul 2013 11:43:12 +0530 amf: Resequence logs during si-swap of safSi=SC-2N,safApp=OpenSAF [#513] Complete diffstat: ------------------ osaf/services/saf/avsv/avd/avd_role.cc | 3 +++ osaf/services/saf/avsv/avd/avd_sg2Nfsm.cc | 2 -- osaf/services/saf/avsv/avnd/avnd_mbcsv.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) Testing Commands: ----------------- 1. Issue swap on safSi=SC-2N,safApp=OpenSAF 2. Issue swap on application si. Testing, Expected Results: -------------------------- 1. For safSi=SC-2N,safApp=OpenSAF swap, logs are: Jul 22 12:03:04 PM_SC-181 osafamfd[5033]: NO safSi=SC-2N,safApp=OpenSAF Swap initiated Jul 22 12:03:06 PM_SC-181 osafamfd[5033]: NO safSi=SC-2N,safApp=OpenSAF Swap done Jul 22 12:03:06 PM_SC-181 osafamfd[5033]: NO Controller switch over initiated Jul 22 12:03:07 PM_SC-181 osafamfd[5033]: NO Controller switch over done 2. For application si swap, logs are: Jul 22 12:04:30 PM_SC-180 osafamfd[5317]: NO safSi=C,safApp=Test Swap initiated Jul 22 12:04:30 PM_SC-180 osafamfd[5317]: NO safSi=C,safApp=Test Swap done Conditions of Submission: ------------------------- Ack from peer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
