Summary: cpnd, glnd, immnd, mqnd, smfnd: remove sleep in NDs to support amf-adm comp restart[#501] Review request for Trac Ticket(s): #501 Peer Reviewer(s): <<LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE>> Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.3.x, default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- The following command fails to start the restart capable Node directors! amf-adm restart <DN of Node director component> The reason is as below: - The ND component responds to AMF in the compterminatecallback. But, there is a sleep(1) after the saAmfResponse() inside this compterminatecallback. - Upon receiving the response for terminatecallback, AMF re-INSTANTIATEs the component - The instnatiation of the component fails because the process is still alive and so start_daemon fails. Solution: The patch removes the sleep and exits immediately after the response to AMF. changeset 38ce7a80d58a326489a8d3b4c8dc74782c330307 Author: [email protected] Date: Mon, 22 Jul 2013 16:38:27 +0530 cpnd, glnd, immnd, mqnd, smfnd: remove sleep in NDs to support amf-adm comp restart [#501] Complete diffstat: ------------------ osaf/services/saf/cpsv/cpnd/cpnd_amf.c | 5 +++-- osaf/services/saf/glsv/glnd/glnd_amf.c | 6 +++--- osaf/services/saf/immsv/immnd/immnd_amf.c | 12 +++++++++--- osaf/services/saf/mqsv/mqnd/mqnd_amf.c | 5 ++--- osaf/services/saf/smfsv/smfnd/smfnd_amf.c | 6 +++--- 5 files changed, 20 insertions(+), 14 deletions(-) Testing Commands: ----------------- Without this patch, the following command fails: amf-adm restart <DN of OpenSAF Node director component> Testing, Expected Results: -------------------------- With this patch, the following command succeeds: amf-adm restart <DN of OpenSAF Node director component> Conditions of Submission: ------------------------- Ack from AndersBj, Ingvar, Neel, Nagendra, Ramesh. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
