Summary: cpsv: create non-collocated replica Imm run-time object maximum on 3 
node [#479] 
Review request for Trac Ticket(s): #479
Peer Reviewer(s): Sirisha & Ramesh
Pull request to: mahesh
Affected branch(es): opensaf-4.2.x, opensaf-4.3.x & default
Development branch: default

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        y
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------
According to Ckpt non-collocated ckpt implementation the cluster can have max 3 
replicas 
and minimum of 2 replicas,if the non-collocated ckpt is opened on controller 
initially ,
by default cpsv service will create 2 replicas each one on controllers ,
else the non-collocated ckpt is opened on payload initially,by default cpsv 
service will create 3 replicas  
one on the payload and other each one on controllers,so any further opens form 
any other payload is not 
required to create replicas  locally.All other node ckpt application will 
access the data form the
default created active replica. 

changeset c7b2f4012768886003533a93e0ac90186efb0f83
Author: A V Mahesh <[email protected]>
Date:   Fri, 26 Jul 2013 09:09:53 +0530

        cpsv: create non-collocated replica Imm run-time object maximum on 3 
node
        [#479]


Complete diffstat:
------------------
 osaf/services/saf/cpsv/cpd/cpd_proc.c |  54 
+++++++++++++++++++++++++++++++++++++++---------------
 1 files changed, 39 insertions(+), 15 deletions(-)


Testing Commands:
-----------------
Create non-collocated  ckpt on more thane 3 nodes 

Testing, Expected Results:
--------------------------
Only max of 3 replicas Imm run-time objects  should be created 

Conditions of Submission:
-------------------------
 <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to