Ack.
Thanks
-Nagu
-----Original Message-----
From: Praveen Malviya
Sent: 02 August 2013 09:27
To: hans.fe...@ericsson.com; Nagendra Kumar
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for amfnd: mark CSI state assigning for
quiesced SI in comp restart recovery [#491]
Summary: amfnd: mark CSI state assigning for quiesced SI in comp restart
recovery [#491] Review request for Trac Ticket(s):amf [#491] Peer
Reviewer(s):Hans F., Nagendra Pull request to: <<LIST THE PERSON WITH PUSH
ACCESS HERE>> Affected branch(es):All Development branch: <<IF ANY GIVE THE
REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please see the ticket for analysis and commit message below.
changeset a045dbbbd5d2a00a0420aa6cbac11002a3a07121
Author: praveen.malv...@oracle.com
Date: Fri, 02 Aug 2013 07:17:52 +0530
amfnd: mark CSI state assigning for quiesced SI in comp restart recovery
[#491] A component is faulted with component restart recovery. During
this
restarting phase, active or quiescing states of assigned SIs may change
to
quiesced state due to fault in the any other component of same SU with
recovery component fail-over. If the restartable component gets
instantiated before the removal of assignment, then AMF should assign
quiesced state to it. AMF marks CSIs unassigned when it gets susi
modification event from AMFD. So in this case all CSIs of the components
should be marked assigning before giving callback to component.
Complete diffstat:
------------------
osaf/services/saf/avsv/avnd/avnd_comp.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
As per ticket description
Testing, Expected Results:
--------------------------
Operation successful and Sg should be stable.
Conditions of Submission:
-------------------------
Ack from Hans or Nagendra
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y y
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
