Summary: IMM: Correction in finalizeSync for veteran implementer-check [#551]
Review request for Trac Ticket(s): 551
Peer Reviewer(s): Neel
Pull request to:
Affected branch(es): opensaf-4.3.x; default(4.4)
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 7a0fd18dc1aad702cb28207fbea1cfcd262ac906
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Thu, 22 Aug 2013 16:17:42 +0200
IMM: Correction in finalizeSync for veteran implementer-check [#551]
THe check of consistent mapping between implementer-name and
impleneter-id
(actual currently connected oi-handle) done in ImmModel::finalizeSync
for
veteran nodes is corrected to ignore also the case when an
implementer-name
gets both disconnected and re-connected in the fevs gap between the
finalizeSync message being generated by the immnd coord and that message
arriving over fevs at all nodes including immnd coord.
Complete diffstat:
------------------
osaf/services/saf/immsv/immnd/ImmModel.cc | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
Testing Commands:
-----------------
Difficult to reproduce.
The bug has been there since the GA of OpenSAF 4.3 and has only been reported
once and recently. If you really want to reproduce it then simplesrt would
probably be some kind of fault injection. You need to disconnect the implementer
and reconnect it just after finalizeSync has been generated by the coord, but
before
that mesage comes back over fevs. A sleep in immnd_evt just before sending the
finalizeSync messafe from the coord would help, with syslog prinouts when sleep
starts. Then release and re-attach the implementer before the sleep ends.
Possibly using immapplier to cvontrol a test OI.
Testing, Expected Results:
--------------------------
Without the patch, veteran immnds should abort in finalizeSync when the
above described sequence happens. With the patch the veteran immnds
should not abort, only print an informatiove NOtice message.
Conditions of Submission:
-------------------------
Ack from Neel.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
