Hi Zoran, yes, it is Ack for #549, #550 and #552(while pushing remove the two lines).
/Neel. On Thursday 29 August 2013 06:51 PM, Neelakanta Reddy wrote: > Hi Zoran, > > yes, it is Ack for #549, #550 and #552(while pushing remove the two > lines). > > /Neel. > > > On Thursday 29 August 2013 06:30 PM, Zoran Milinkovic wrote: >> Hi Neel, >> >> Good point. >> When I was working on the code, I totally forgot it's SaNameT type >> and not a string (char *). >> I will that two lines before I push the code. >> >> Is it ack for all three #549, #550 and #552 or only for #552 ? >> >> Thanks, >> Zoran >> >> -----Original Message----- >> From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] >> Sent: den 29 augusti 2013 14:41 >> To: Zoran Milinkovic >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [PATCH 0 of 1] Review Request for IMMTOOL: Cleanup the >> code and fix memory problem [#552] >> >> Hi zoran, >> >> Reviewed and tested the patch. >> Ack with minor comment. >> >> comment: >> >> Adding "\0" at the end of the string is not required. The imma >> saImmOmCcbObjectDelete will take care of adding "\0" at the end of >> the object, >> >> objectName.value[objectName.length] = 0; >> >> your patch worked because you sent only length but not length+1. >> >> /Neel. >> >> On Tuesday 27 August 2013 05:27 PM, Zoran Milinkovic wrote: >>> Summary: IMMTOOL: Cleanup the code and fix memory problem [#552] >>> Review request for Trac Ticket(s): 552 Peer Reviewer(s): Neel Pull >>> request to: Zoran Affected branch(es): default(4.4) Development >>> branch: default(4.4) >>> >>> -------------------------------- >>> Impacted area Impact y/n >>> -------------------------------- >>> Docs n >>> Build system n >>> RPM/packaging n >>> Configuration files n >>> Startup scripts n >>> SAF services n >>> OpenSAF services n >>> Core libraries n >>> Samples n >>> Tests y >>> Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> --------------------------------------------- >>> >>> changeset 0cdd2a5765b3dbf0a471ddb0c09bd99587ec1e9d >>> Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> >>> Date: Tue, 27 Aug 2013 10:53:50 +0200 >>> >>> IMMTOOL: Cleanup the code and fix memory problem [#552] >>> >>> Cleanup IMM test code and fix memory problems reported by valgrind. >>> >>> >>> Complete diffstat: >>> ------------------ >>> tests/immsv/common/immtest.c | 4 ++++ >>> tests/immsv/implementer/test_SaImmOiRtAttrUpdateCallbackT.c | 2 +- >>> tests/immsv/implementer/test_cleanup.c | 3 ++- >>> tests/immsv/management/test_cleanup.c | 3 ++- >>> tests/immsv/management/test_saImmOmAdminOwnerFinalize.c | 1 + >>> tests/immsv/management/test_saImmOmInitialize.c | 1 + >>> tests/immsv/management/test_saImmOmThreadInterference.c | 10 >>> +++++++--- >>> 7 files changed, 18 insertions(+), 6 deletions(-) >>> >>> >>> Testing Commands: >>> ----------------- >>> valgrind --leak-check=full --show-reachable=yes immomtest valgrind >>> --leak-check=full --show-reachable=yes immoitest >>> >>> >>> Testing, Expected Results: >>> -------------------------- >>> Running immoitest and immomtest using valgrind, valgrind should not >>> report any memory leak. >>> >>> >>> Conditions of Submission: >>> ------------------------- >>> Ack from Neel >>> >>> >>> Arch Built Started Linux distro >>> ------------------------------------------- >>> mips n n >>> mips64 n n >>> x86 n n >>> x86_64 n n >>> powerpc n n >>> powerpc64 n n >>> >>> >>> Reviewer Checklist: >>> ------------------- >>> [Submitters: make sure that your review doesn't trigger any >>> checkmarks!] >>> >>> >>> Your checkin has not passed review because (see checked entries): >>> >>> ___ Your RR template is generally incomplete; it has too many blank >>> entries >>> that need proper data filled in. >>> >>> ___ You have failed to nominate the proper persons for review and push. >>> >>> ___ Your patches do not have proper short+long header >>> >>> ___ You have grammar/spelling in your header that is unacceptable. >>> >>> ___ You have exceeded a sensible line length in your >>> headers/comments/text. >>> >>> ___ You have failed to put in a proper Trac Ticket # into your commits. >>> >>> ___ You have incorrectly put/left internal data in your comments/files >>> (i.e. internal bug tracking tool IDs, product names etc) >>> >>> ___ You have not given any evidence of testing beyond basic build >>> tests. >>> Demonstrate some level of runtime or other sanity testing. >>> >>> ___ You have ^M present in some of your files. These have to be >>> removed. >>> >>> ___ You have needlessly changed whitespace or added whitespace crimes >>> like trailing spaces, or spaces before tabs. >>> >>> ___ You have mixed real technical changes with whitespace and other >>> cosmetic code cleanup changes. These have to be separate commits. >>> >>> ___ You need to refactor your submission into logical chunks; there is >>> too much content into a single commit. >>> >>> ___ You have extraneous garbage in your review (merge commits etc) >>> >>> ___ You have giant attachments which should never have been sent; >>> Instead you should place your content in a public tree to be >>> pulled. >>> >>> ___ You have too many commits attached to an e-mail; resend as threaded >>> commits, or place in a public tree for a pull. >>> >>> ___ You have resent this content multiple times without a clear >>> indication >>> of what has changed between each re-send. >>> >>> ___ You have failed to adequately and individually address all of the >>> comments and change requests that were proposed in the initial >>> review. >>> >>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >>> >>> ___ Your computer have a badly configured date and time; confusing the >>> the threaded patch review. >>> >>> ___ Your changes affect IPC mechanism, and you don't present any >>> results >>> for in-service upgradability test. >>> >>> ___ Your changes affect user manual and documentation, your patch >>> series >>> do not contain the patch that updates the Doxygen manual. >>> > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
