Ack. Tested by executing ntftest. It runs 142 tests.
Thanks, Praveen On 04-Sep-13 9:15 PM, Carl Johannesson wrote: > Hi, > I know, there are still some valgrind issues to take care of, I will do that. > 4.2 and 4.3 ? I don't know, is it necessary? > /Carl > -----Original Message----- > From: Hans Feldt > Sent: den 4 september 2013 14:11 > To: Lennart Lund; Carl Johannesson; praveen.malv...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 0 of 1] Review Request for ntftest: Fix and complete test > suites [303] > > Ack with tiny comment "Life Cykel" should be fixed... > > I see some issues when I run ntftest under valgrind. I hope you will analyze > those? > > How about the 4.2 and 4.3 branches, will you fix ntftest there also? > > Thanks, > Hans > >> -----Original Message----- >> From: Lennart Lund >> Sent: den 4 september 2013 13:28 >> To: Carl Johannesson; Hans Feldt; praveen.malv...@oracle.com; Lennart >> Lund >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: RE: [PATCH 0 of 1] Review Request for ntftest: Fix and >> complete test suites [303] >> >> Hi, >> >> Comment: >> >> * The local file util.h no longer exists but is still included as local in >> 31 files >> (replace #include "util.h" with #include <util.h>). Same also >> applies to saNtf.h and utest.h >> >> Ack >> >> Thanks' >> Lennart >> >>> -----Original Message----- >>> From: Carl Johannesson >>> Sent: den 4 september 2013 10:56 >>> To: Hans Feldt; Lennart Lund; praveen.malv...@oracle.com >>> Cc: opensaf-devel@lists.sourceforge.net >>> Subject: [PATCH 0 of 1] Review Request for ntftest: Fix and complete >>> test suites [303] >>> >>> Summary: ntftests: Fix and complete test suites [#303] Review >>> request for Trac Ticket(s): <<IF ANY LIST THE #>> Peer Reviewer(s): >>> Hans F, Lennart L, Praveen Malviya Pull request to: <<LIST THE >>> PERSON WITH PUSH ACCESS >>> HERE>> Affected branch(es): 4.3x Development branch: default >>> >>> -------------------------------- >>> Impacted area Impact y/n >>> -------------------------------- >>> Docs n >>> Build system n >>> RPM/packaging n >>> Configuration files n >>> Startup scripts n >>> SAF services n >>> OpenSAF services n >>> Core libraries n >>> Samples n >>> Tests y >>> Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> --------------------------------------------- >>> >>> changeset 57dffca36bc91d323b51579ffa36f8ed8a71cbc0 >>> Author: carl.johannes...@ericsson.se >>> Date: Wed, 04 Sep 2013 10:44:07 +0200 >>> >>> ntftests: Fix and complete test suites [#303] >>> >>> A few test cases has been updated and corrected to make sure that >>> all test >>> cases pass. Also, own test/util files has been removed, Ntf now use >>> the unit >>> test framework provided files. Valgrind has also been used to >>> remove a large number >>> of memory leaks. >>> >>> >>> Removed Files: >>> -------------- >>> tests/ntfsv/test.c >>> tests/ntfsv/test.h >>> tests/ntfsv/util.c >>> tests/ntfsv/util.h >>> >>> >>> Complete diffstat: >>> ------------------ >>> tests/ntfsv/Makefile.am | >>> 10 +- >>> tests/ntfsv/README | >>> 21 ++-- >>> tests/ntfsv/ntfsv_test_classes.xml | >>> 23 +++++ >>> tests/ntfsv/test.c | >>> 182 ---------------------------------- >>> -------- >>> tests/ntfsv/test.h | >>> 81 ------------------- >>> tests/ntfsv/test_ntfFilterVerification.c | >>> 67 ++++++++------ >>> tests/ntfsv/test_ntf_imcn.c | 387 >>> +++++++++++++++++++++++++++++++++++++++----------------------------- >>> +++++++++++++++++++++++++++++++++++++++-- >>> -------------------- >>> tests/ntfsv/test_ntf_imcn.h | >>> 7 +- >>> tests/ntfsv/tet_NotificationContentVerification.c | >>> 52 +++++++---- >>> - >>> tests/ntfsv/tet_ntf_common.c | >>> 55 +++++++----- >>> tests/ntfsv/tet_ntf_common.h | >>> 6 + >>> tests/ntfsv/tet_ntf_main.c | >>> 5 +- >>> tests/ntfsv/tet_saNtfAlarmNotificationAllocate.c | >>> 6 +- >>> tests/ntfsv/tet_saNtfAlarmNotificationFilterAllocate.c | >>> 4 +- >>> tests/ntfsv/tet_saNtfArrayValAllocate.c | >>> 2 +- >>> tests/ntfsv/tet_saNtfArrayValGet.c | >>> 41 +++++---- >>> tests/ntfsv/tet_saNtfAttributeChangeNotificationAllocate.c | >>> 9 +- >>> tests/ntfsv/tet_saNtfAttributeChangeNotificationFilterAllocate.c | >>> 6 +- >>> tests/ntfsv/tet_saNtfDispatch.c | >>> 3 +- >>> tests/ntfsv/tet_saNtfFinalize.c | >>> 3 +- >>> tests/ntfsv/tet_saNtfInitialize.c | >>> 3 +- >>> tests/ntfsv/tet_saNtfMiscellaneousNotificationAllocate.c | >>> 11 +- >>> tests/ntfsv/tet_saNtfNotificationCallbackT.c | >>> 4 +- >>> tests/ntfsv/tet_saNtfNotificationDiscardedCallbackT.c | 261 >>> ++++++++++++++++++++++++++++++------------------------------- >>> tests/ntfsv/tet_saNtfNotificationReadFinalize.c | >>> 5 +- >>> tests/ntfsv/tet_saNtfNotificationReadInitialize.c | >>> 20 +++- >>> tests/ntfsv/tet_saNtfNotificationReadNext.c | 58 >>> ++++++++++++- >>> tests/ntfsv/tet_saNtfNotificationSend.c | >>> 51 ++++++++++- >>> tests/ntfsv/tet_saNtfNotificationSubscribe.c | >>> 2 +- >>> tests/ntfsv/tet_saNtfNotificationUnsubscribe.c | >>> 2 +- >>> tests/ntfsv/tet_saNtfObjectCreateDeleteNotificationAllocate.c | >>> 7 +- >>> tests/ntfsv/tet_saNtfObjectCreateDeleteNotificationFilterAllocate.c | >>> 6 +- >>> tests/ntfsv/tet_saNtfPtrValAllocate.c | >>> 4 +- >>> tests/ntfsv/tet_saNtfPtrValGet.c | >>> 41 +++++---- >>> tests/ntfsv/tet_saNtfSecurityAlarmNotificationAllocate.c | >>> 7 +- >>> tests/ntfsv/tet_saNtfSecurityAlarmNotificationFilterAllocate.c | >>> 6 +- >>> tests/ntfsv/tet_saNtfSelectionObjectGet.c | >>> 3 +- >>> tests/ntfsv/tet_saNtfStateChangeNotificationAllocate.c | >>> 7 +- >>> tests/ntfsv/tet_saNtfStateChangeNotificationFilterAllocate.c | >>> 6 +- >>> tests/ntfsv/util.c | >>> 113 -------------------------- >>> tests/ntfsv/util.h | >>> 47 ----------- >>> 41 files changed, 667 insertions(+), 967 deletions(-) >>> >>> >>> Testing Commands: >>> ----------------- >>> ntftest >>> >>> >>> Testing, Expected Results: >>> -------------------------- >>> all test cases should PASS. >>> >>> >>> Conditions of Submission: >>> ------------------------- >>> - >>> >>> >>> Arch Built Started Linux distro >>> ------------------------------------------- >>> mips n n >>> mips64 n n >>> x86 n n >>> x86_64 n n >>> powerpc n n >>> powerpc64 n n >>> >>> >>> Reviewer Checklist: >>> ------------------- >>> [Submitters: make sure that your review doesn't trigger any >>> checkmarks!] >>> >>> >>> Your checkin has not passed review because (see checked entries): >>> >>> ___ Your RR template is generally incomplete; it has too many blank entries >>> that need proper data filled in. >>> >>> ___ You have failed to nominate the proper persons for review and push. >>> >>> ___ Your patches do not have proper short+long header >>> >>> ___ You have grammar/spelling in your header that is unacceptable. >>> >>> ___ You have exceeded a sensible line length in your >>> headers/comments/text. >>> >>> ___ You have failed to put in a proper Trac Ticket # into your commits. >>> >>> ___ You have incorrectly put/left internal data in your comments/files >>> (i.e. internal bug tracking tool IDs, product names etc) >>> >>> ___ You have not given any evidence of testing beyond basic build tests. >>> Demonstrate some level of runtime or other sanity testing. >>> >>> ___ You have ^M present in some of your files. These have to be removed. >>> >>> ___ You have needlessly changed whitespace or added whitespace crimes >>> like trailing spaces, or spaces before tabs. >>> >>> ___ You have mixed real technical changes with whitespace and other >>> cosmetic code cleanup changes. These have to be separate commits. >>> >>> ___ You need to refactor your submission into logical chunks; there is >>> too much content into a single commit. >>> >>> ___ You have extraneous garbage in your review (merge commits etc) >>> >>> ___ You have giant attachments which should never have been sent; >>> Instead you should place your content in a public tree to be pulled. >>> >>> ___ You have too many commits attached to an e-mail; resend as threaded >>> commits, or place in a public tree for a pull. >>> >>> ___ You have resent this content multiple times without a clear indication >>> of what has changed between each re-send. >>> >>> ___ You have failed to adequately and individually address all of the >>> comments and change requests that were proposed in the initial review. >>> >>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >>> >>> ___ Your computer have a badly configured date and time; confusing the >>> the threaded patch review. >>> >>> ___ Your changes affect IPC mechanism, and you don't present any results >>> for in-service upgradability test. >>> >>> ___ Your changes affect user manual and documentation, your patch series >>> do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
