Oh well... Ack if you add something like this in the code: // TODO(nagu) remove saAmfSUPreInstantiable check and move into m_AVD_APP_SU_IS_INSVC
Thanks, Hans On 09/09/2013 08:56 AM, Nagendra Kumar wrote: > Hi Hans, > This would be done as part of ticket # 445. Adding it in > m_AVD_APP_SU_IS_INSVC will need more fixes and testing. The same changes were > done in SU unlocking but was missing in SG unlock. > > Thanks > -Nagu > > -----Original Message----- > From: Hans Feldt [mailto:hans.fe...@ericsson.com] > Sent: 09 September 2013 12:18 > To: Nagendra Kumar > Cc: hans.nordeb...@ericsson.com; Praveen Malviya; > opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 1 of 1] amfsv: Donot assign SUSI to instantiating SU > during SG unlock [#562] > > I don't understand why the change is not done in the m_AVD_APP_SU_IS_INSVC > macro instead? > Thanks, > Hans > > On 09/04/2013 02:18 PM, nagendr...@oracle.com wrote: >> osaf/services/saf/amf/amfd/avd_sgproc.cc | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> >> diff --git a/osaf/services/saf/amf/amfd/avd_sgproc.cc >> b/osaf/services/saf/amf/amfd/avd_sgproc.cc >> --- a/osaf/services/saf/amf/amfd/avd_sgproc.cc >> +++ b/osaf/services/saf/amf/amfd/avd_sgproc.cc >> @@ -1408,7 +1408,10 @@ uint32_t avd_sg_app_sg_admin_func(AVD_CL >> for (i_su = sg->list_of_su; i_su != NULL; i_su = >> i_su->sg_list_su_next) { >> m_AVD_GET_SU_NODE_PTR(cb, i_su, i_su_node_ptr); >> >> - if (m_AVD_APP_SU_IS_INSVC(i_su, i_su_node_ptr)) { >> + if (m_AVD_APP_SU_IS_INSVC(i_su, i_su_node_ptr) && >> + ((i_su->saAmfSUPreInstantiable) ? >> + (i_su->saAmfSUPresenceState == >> + SA_AMF_PRESENCE_INSTANTIATED):true)) { >> avd_su_readiness_state_set(i_su, >> SA_AMF_READINESS_IN_SERVICE); >> } >> } >> >> > > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
