Summary: amfnd: terminate comps when failed NPI SU is in TERMINATING state
[#338]
Review request for Trac Ticket(s): amf #338
Peer Reviewer(s): Hans F., Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):4.3 and 4.2
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please see the commit log below.
changeset 78aef99585d4575407330597b6593506ac2f8ab6
Author: praveen.malv...@oracle.com
Date: Thu, 12 Sep 2013 17:58:01 +0530
amfnd: terminate comps when failed NPI SU is in TERMINATING state
[#338] In
case of NPI SU, failed component is cleaned up when AMFD sends quiesced
HA
state to AMFND. In this issue when SU is still instantiating, one
instantiated component failed with suFailover recovery. When AMFD sends
quiesced HA state, AMFND moves SU to terminating state without cleaning
up
failed component. When another component gets fully instantiated, SU FSM
should trigger termination of healthy components and cleanup of failed
components. This patch ensures that if SU moves from Instantiating to
Terminating state due to suFailover then after instantiation of all
the components SU FSM will terminate or cleanup all components
and will, thus, finish quiesced assignments.
Complete diffstat:
------------------
osaf/services/saf/avsv/avnd/avnd_clc.c | 3 ++-
osaf/services/saf/avsv/avnd/avnd_susm.c | 28 ++++++++++++++++++++++++++++
2 files changed, 30 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Tested case 2 of bug desciption with the attached configuration of ticket.
Tested case 2 with Component monitoring with commands with the attached
configuration of ticket.
Will test:
1)case 1
2)sufailover when application is already up and running
Testing, Expected Results:
--------------------------
No longer seeing SU getting stuck in Terminating state.
Conditions of Submission:
-------------------------
Ack from Hans or Nags.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y y
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
