Summary: Amf: Change NCS_ENV_COMPONENT_ERROR_SRC to OSAF_COMPONENT_ERROR_SOURCE [#429] Review request for Trac Ticket(s): #429 Peer Reviewer(s): Hans F, Hans N, Mathi, Praveen Pull request to: Affected branch(es): Default Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset d9165a5ed6d07dc0c5be1cf77313c1150fbd01aa Author: Nagendra Kumar<[email protected]> Date: Tue, 17 Sep 2013 16:44:43 +0530 Amf: Change NCS_ENV_COMPONENT_ERROR_SRC to OSAF_COMPONENT_ERROR_SOURCE [#429] Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/avnd_cam.c | 4 ++-- osaf/services/saf/amf/amfnd/avnd_cbq.c | 18 +++++++++--------- osaf/services/saf/amf/amfnd/avnd_chc.c | 4 ++-- osaf/services/saf/amf/amfnd/avnd_clc.c | 8 ++++---- osaf/services/saf/amf/amfnd/avnd_comp.c | 2 +- osaf/services/saf/amf/amfnd/avnd_err.c | 10 +++++----- osaf/services/saf/amf/amfnd/avnd_mon.c | 2 +- osaf/services/saf/amf/amfnd/include/avnd_err.h | 38 +++++++++++++++++++------------------- 8 files changed, 43 insertions(+), 43 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- The below information will be provided in section 2.2.9 of AMF PR Doc: 2.2.9 Amf Detected source of errors: Amf exports an environment variable OSAF_COMPONENT_ERROR_SOURCE while running application's CLEANUP Command. This variable indicates 'Amf Detected sources of erros' just before cleaning up the application. Those sources of errors are : OSAF_ERR_SRC_REP = 1, /* comp reports an error */ OSAF_ERR_SRC_HC = 2, /* healthcheck failure */ OSAF_ERR_SRC_PM = 3, /* passive monitoring failure */ OSAF_ERR_SRC_AM = 3, /* active monitoring failure (AM_START/STOP execution failed) */ OSAF_ERR_SRC_CMD_FAILED = 4, /* AMF command fails (INSTANTIATE cmd fails for NPI comp as a result of CSI assignment) */ OSAF_ERR_SRC_CBK_HC_TIMEOUT = 5, /* AMF health check callback times out */ OSAF_ERR_SRC_CBK_HC_FAILED = 6, /* AMF callback failed */ OSAF_ERR_SRC_AVA_DN = 7, /* AvA down */ OSAF_ERR_SRC_PXIED_REG_TIMEOUT = 8, /* orphaned state timed out */ OSAF_ERR_SRC_CBK_CSI_SET_TIMEOUT = 9, /* AMF csi set callback times out */ OSAF_ERR_SRC_CBK_CSI_REM_TIMEOUT = 10, /* AMF csi rem callback times out */ OSAF_ERR_SRC_CBK_CSI_SET_FAILED = 11, /* AMF callback failed */ OSAF_ERR_SRC_CBK_CSI_REM_FAILED = 12, /* AMF callback failed */ OSAF_ERR_SRC_QSCING_COMPL_TIMEOUT =13, /* AMF qscing complete times out */ Example Usage of OSAF_COMPONENT_ERROR_SOURCE: User can create a core dump of application if 'source of error' is OSAF_ERR_SRC_CBK_CSI_SET_TIMEOUT(10) during cleanup command: if [ $OSAF_COMPONENT_ERROR_SOURCE -eq 10 ]; then kill -5 <application's pid> logger -st $name "Generated the core dump.." fi Conditions of Submission: ------------------------- Ack from peers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
