Hi, Some minor comments: - there is one realloc in clc.c that needs to be reworked - there are a lot of "stupid" comments about alloc/free such as: "free the memory" or "allocate the ...", that could be removed. Not neccessarily in the same changeset...
I also checked how memory allocation is done for MDS messages. For AMFD messages it seems like memory is allocated with malloc in e.g. d2nedu.c and freed with free in d2nmsg.c. Both belong to libs/common/amf. But for AVA messages, memory is allocated using new in avnd_mds_flat_ava_dec() and freed with free in avsv_nda_ava_msg_free which belongs to libs/common/amf. This will not work? I think the change in avnd_mds_flat_ava_dec() needs to be reverted. Thanks, Hans On 27 September 2013 16:43, Hans Nordeback <hans.nordeb...@ericsson.com> wrote: > Summary: amfnd: replace malloc/calloc/free with new and delete [#94] > Review request for Trac Ticket(s): #94 > Peer Reviewer(s): hansf, nagendra, praveen > Pull request to: > Affected branch(es): default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset 6ab7a6cc4b4a1d002d67e1cda6d7201cc8bdf879 > Author: Hans Nordeback <hans.nordeb...@ericsson.com> > Date: Fri, 27 Sep 2013 16:39:13 +0200 > > amfnd: replace malloc/calloc/free with new and delete [#94] > > Replace malloc/calloc/free with new and delete. > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/amfnd/cbq.cc | 17 +--- > osaf/services/saf/amf/amfnd/chc.cc | 5 +- > osaf/services/saf/amf/amfnd/ckpt_updt.cc | 14 ++-- > osaf/services/saf/amf/amfnd/clc.cc | 29 ++++---- > osaf/services/saf/amf/amfnd/comp.cc | 36 ++-------- > osaf/services/saf/amf/amfnd/compdb.cc | 92 ++++++++++++---------------- > osaf/services/saf/amf/amfnd/cpm.cc | 7 +- > osaf/services/saf/amf/amfnd/di.cc | 279 > +++++++++++++++++++++++++++++++++++++++---------------------------------------------- > osaf/services/saf/amf/amfnd/evt.cc | 11 +-- > osaf/services/saf/amf/amfnd/hcdb.cc | 20 ++---- > osaf/services/saf/amf/amfnd/mbcsv.cc | 8 +- > osaf/services/saf/amf/amfnd/mds.cc | 8 +- > osaf/services/saf/amf/amfnd/mon.cc | 23 ++---- > osaf/services/saf/amf/amfnd/pg.cc | 33 ++------- > osaf/services/saf/amf/amfnd/pgdb.cc | 26 ++----- > osaf/services/saf/amf/amfnd/proxy.cc | 91 +++++++++++---------------- > osaf/services/saf/amf/amfnd/proxydb.cc | 37 ++++------- > osaf/services/saf/amf/amfnd/sidb.cc | 36 +++------- > osaf/services/saf/amf/amfnd/su.cc | 3 +- > osaf/services/saf/amf/amfnd/sudb.cc | 10 +-- > osaf/services/saf/amf/amfnd/susm.cc | 4 +- > osaf/services/saf/amf/amfnd/util.cc | 15 +--- > 22 files changed, 320 insertions(+), 484 deletions(-) > > > Testing Commands: > ----------------- > <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> > > > Testing, Expected Results: > -------------------------- > <<PASTE COMMAND OUTPUTS / TEST RESULTS>> > > > Conditions of Submission: > ------------------------- > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
