Ok. In future, if we have to set different TIPC importance for different processes(say based on the nature of service they provide) then the idea of using a single configure option may not help. What do you think?
-AVM On 10/11/2013 12:45 PM, Ingvar Bergström wrote: > Hi AVM, > I have no statistics. What we observed is that in case an application is > running on the same nodes also using TIPC at low importance, the TIPC (low > importance)buffers sometimes are filled and packets are lost. > What we want to have is the possibility to raise the TIPC importance level > for OpenSAF above the application importance if needed, to minimize the risk > for loss of packages. > > That's the motivation for the ticket. > > Thanks > Ingvar > > -----Original Message----- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: den 11 oktober 2013 08:54 > To: Ingvar Bergström > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 0 of 1] Review Request for mds #589 > > Hi Ingvar, > > Some time back in the context of IMM loading large objects bug, we also > given a try with immnd with MEDIUM importance , but we failed to observe > congestion over come statistics. > > Can you please share some statistics that you observed with > `TIPC_LOW_IMPORTANCE` Vs `TIPC_MEDIUM_IMPORTANCE` I hope this is the > motivation behind this ticket . > > -AVM > > > On 10/10/2013 12:22 PM, Ingvar Bergstrom wrote: >> Summary: mds: configurable TIPC importance Review request for Trac >> Ticket(s): 589 Peer Reviewer(s): AVM Pull request to: >> Affected branch(es): 4.2 4.3 default >> Development branch: default >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services n >> OpenSAF services n >> Core libraries y >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> mds: configurable TIPC importance >> >> changeset 64d258e667d04fb37f0c8aed55dd0f6c50f66a4b >> Author: Ingvar Bergstrom <ingvar.bergst...@ericsson.com> >> Date: Thu, 10 Oct 2013 08:40:17 +0200 >> >> mds: configurable TIPC importance [#589] >> >> The default TIPC importance (TIPC_LOW_IMPORTANCE) can be changed by >> defining >> TIPCIMPORTANCE at compile time. e.g. >> -DTIPCIMPORTANCE=TIPC_HIGH_IMPORTANCE. >> Possible values are: TIPC_LOW_IMPORTANCE, TIPC_MEDIUM_IMPORTANCE and >> TIPC_HIGH_IMPORTANCE >> >> >> Complete diffstat: >> ------------------ >> osaf/libs/core/mds/include/mds_dt_tipc.h | 8 ++++++++ >> osaf/libs/core/mds/mds_dt_tipc.c | 14 ++++++++++++++ >> 2 files changed, 22 insertions(+), 0 deletions(-) >> >> >> Testing Commands: >> ----------------- >> >> >> Testing, Expected Results: >> -------------------------- >> >> >> Conditions of Submission: >> ------------------------- >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 y y >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any >> checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
