Summary:amfnd : reset assignment flag when no assignment pending on SU [#403] Review request for Trac Ticket(s):amf #403 Peer Reviewer(s): Hans F., Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es):All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Refloating patch after considering the case, when AMFND issues remove callbacks to application components in shutdown case. In such a case removal is not initiated by AMFD by sending explicit assignment request to AMFND. Please see also the commit log below. changeset b7f699a4893936485254a58061bbedb9e99530ec Author: [email protected] Date: Tue, 15 Oct 2013 11:44:18 +0530 amfnd : reset assignment flag when no assignment pending on SU [#403] When responding to AMFD for any assignment, AMFND should call m_AVND_SU_ASSIGN_PEND_RESET(su) only after checking the assignment states of all SIs in SU. if any SI is still in assigning/removing state then flag should not be reset. Change of this patch is needed in situation when AMFND gets per susi level assignments from AMFD like SI dep related configuration or during fresh assignments. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/di.cc | 31 +++++++++++++++++++++++++++++-- osaf/services/saf/amf/amfnd/susm.cc | 2 ++ osaf/services/saf/amf/amfnd/term.cc | 1 + 3 files changed, 32 insertions(+), 2 deletions(-) Testing Commands: ----------------- opensaf shutdown on node having application installed in it. Testing, Expected Results: -------------------------- works fine Conditions of Submission: ------------------------- Ack from reviwers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
