Ack from me. I would like to see this pushed with two changesets, one for amfd and one for amfnd. That makes it easier with the commit message e.g. "amfd: replace malloc/calloc with new and delete [#94]"
Another thing, most likely some code in osaf/libs/common/amf is now obsolote. So maybe as a next step you check if it can be removed? Thanks, Hans On 11/05/2013 01:06 PM, Hans Nordeback wrote: > osaf/services/saf/amf/amfd/app.cc | 7 +- > osaf/services/saf/amf/amfd/apptype.cc | 12 +- > osaf/services/saf/amf/amfd/chkop.cc | 19 +- > osaf/services/saf/amf/amfd/comp.cc | 7 +- > osaf/services/saf/amf/amfd/compcstype.cc | 27 +- > osaf/services/saf/amf/amfd/comptype.cc | 7 +- > osaf/services/saf/amf/amfd/csi.cc | 23 +- > osaf/services/saf/amf/amfd/csiattr.cc | 33 +- > osaf/services/saf/amf/amfd/cstype.cc | 25 +- > osaf/services/saf/amf/amfd/ctcstype.cc | 9 +- > osaf/services/saf/amf/amfd/dmsg.cc | 8 +- > osaf/services/saf/amf/amfd/imm.cc | 636 > ++++++++++------------- > osaf/services/saf/amf/amfd/include/amfd.h | 2 +- > osaf/services/saf/amf/amfd/include/imm.h | 63 ++- > osaf/services/saf/amf/amfd/include/util.h | 1 + > osaf/services/saf/amf/amfd/main.cc | 32 +- > osaf/services/saf/amf/amfd/mds.cc | 20 +- > osaf/services/saf/amf/amfd/ndfsm.cc | 11 +- > osaf/services/saf/amf/amfd/ndmsg.cc | 25 +- > osaf/services/saf/amf/amfd/ndproc.cc | 1 + > osaf/services/saf/amf/amfd/node.cc | 21 +- > osaf/services/saf/amf/amfd/nodegroup.cc | 9 +- > osaf/services/saf/amf/amfd/pg.cc | 12 +- > osaf/services/saf/amf/amfd/role.cc | 13 +- > osaf/services/saf/amf/amfd/sg.cc | 7 +- > osaf/services/saf/amf/amfd/sgproc.cc | 17 +- > osaf/services/saf/amf/amfd/sgtype.cc | 13 +- > osaf/services/saf/amf/amfd/si.cc | 34 +- > osaf/services/saf/amf/amfd/si_dep.cc | 48 +- > osaf/services/saf/amf/amfd/siass.cc | 8 +- > osaf/services/saf/amf/amfd/sirankedsu.cc | 7 +- > osaf/services/saf/amf/amfd/su.cc | 13 +- > osaf/services/saf/amf/amfd/sutcomptype.cc | 7 +- > osaf/services/saf/amf/amfd/sutype.cc | 13 +- > osaf/services/saf/amf/amfd/svctype.cc | 25 +- > osaf/services/saf/amf/amfd/svctypecstypes.cc | 7 +- > osaf/services/saf/amf/amfd/timer.cc | 5 +- > osaf/services/saf/amf/amfd/util.cc | 287 ++++++---- > osaf/services/saf/amf/amfnd/cbq.cc | 17 +- > osaf/services/saf/amf/amfnd/chc.cc | 5 +- > osaf/services/saf/amf/amfnd/ckpt_updt.cc | 14 +- > osaf/services/saf/amf/amfnd/clc.cc | 22 +- > osaf/services/saf/amf/amfnd/comp.cc | 31 +- > osaf/services/saf/amf/amfnd/compdb.cc | 134 ++-- > osaf/services/saf/amf/amfnd/cpm.cc | 7 +- > osaf/services/saf/amf/amfnd/di.cc | 285 ++++----- > osaf/services/saf/amf/amfnd/evt.cc | 11 +- > osaf/services/saf/amf/amfnd/hcdb.cc | 20 +- > osaf/services/saf/amf/amfnd/include/avnd_util.h | 7 + > osaf/services/saf/amf/amfnd/mbcsv.cc | 8 +- > osaf/services/saf/amf/amfnd/mds.cc | 4 +- > osaf/services/saf/amf/amfnd/mon.cc | 22 +- > osaf/services/saf/amf/amfnd/pg.cc | 33 +- > osaf/services/saf/amf/amfnd/pgdb.cc | 26 +- > osaf/services/saf/amf/amfnd/proxy.cc | 91 +-- > osaf/services/saf/amf/amfnd/proxydb.cc | 37 +- > osaf/services/saf/amf/amfnd/sidb.cc | 36 +- > osaf/services/saf/amf/amfnd/su.cc | 3 +- > osaf/services/saf/amf/amfnd/sudb.cc | 10 +- > osaf/services/saf/amf/amfnd/susm.cc | 4 +- > osaf/services/saf/amf/amfnd/util.cc | 310 +++++++++++- > 61 files changed, 1373 insertions(+), 1278 deletions(-) > > > Replace malloc/calloc with new and delete for amfd and amfnd. strdup, > realloc are temporary fixed, more work has to be done. Updated with > with latest review comments. Valgrind run and updated. ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
