Ack with additional patch sent on 11 Nov. Thanks -Nagu
-----Original Message----- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 08 November 2013 01:52 To: Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0 of 2] Review Request for amf #194 Summary: Add support for CSI add/remove in NPI SU Review request for Trac Ticket(s): 194 Peer Reviewer(s): Praveen Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): all Development branch: 4.3 -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 512a056943335d5adaa0f505b1c8320b2d4c399a Author: Hans Feldt <hans.fe...@ericsson.com> Date: Thu, 07 Nov 2013 20:52:52 +0100 amf: add support for CSI add in unlocked NPI SU [#194] changeset 14a6b2a46df025cd5be8d0a62415e18001287784 Author: Hans Feldt <hans.fe...@ericsson.com> Date: Thu, 07 Nov 2013 21:17:11 +0100 amf: add support for CSI remove in unlocked NPI SU [#194] Complete diffstat: ------------------ osaf/services/saf/avsv/avnd/avnd_comp.c | 2 +- osaf/services/saf/avsv/avnd/avnd_susm.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 75 insertions(+), 12 deletions(-) Testing Commands: ----------------- CSI add/remove for comp in PI SU CSI add/remove for comp in NPI SU SI swap after CSI add, NPI SU Misc reg tests Testing, Expected Results: -------------------------- works fine Conditions of Submission: ------------------------- Ack from Praveen Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y ubuntu powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access Free app hosting. Or install the open source package on any LAMP server. Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native! http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
