Summary: amfd: Use correct CLC command to term/clean component [#104] Review request for Trac Ticket(s): #104 Peer Reviewer(s): Hans F, Hans N, Bertil Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts y SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset a4ad0f915271852bf2b65afa61d58dbef7daa318 Author: Nagendra Kumar<nagendr...@oracle.com> Date: Tue, 19 Nov 2013 13:45:33 +0530 amfd: Use correct CLC command to term/clean component [#104] Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 27 +++++++++++++++++++-------- 1 files changed, 19 insertions(+), 8 deletions(-) Testing Commands: ----------------- 1. Create and Change the component type of amf demo: immcfg -c SaAmfCompType safVersion=2,safCompType=AmfDemo1 -a saAmfCtCompCategory=8 -a saAmfCtSwBundle=safSmfBundle=AmfDemo -a saAmfCtDefClcCliTimeout=10000000000 -a saAmfCtDefCallbackTimeout=1000000000 -a s aAmfCtRelPathInstantiateCmd=amf_demo_script -a saAmfCtDefInstantiateCmdArgv=instantiate1 -a saAmfCtRelPathCleanupCmd=amf_dem o_script -a saAmfCtDefCleanupCmdArgv=cleanup1 -a saAmfCtDefQuiescingCompleteTimeout=10000000000 -a saAmfCtDefRecoveryOnError =2 -a saAmfCtDefDisableRestart=0 -a saAmfCtRelPathTerminateCmd=amf_demo_script -a saAmfCtDefTerminateCmdArgv=term1 immcfg -a saAmfCompType=safVersion=2,safCompType=AmfDemo1 safComp=AmfDemo,safSu=SU 1,safSg=AmfDemo,safApp=AmfDemo1 2. amf-adm restart safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1 3. Kill Amf demo. 4. Repeat steps #1 to #2 for NPI demo. Testing, Expected Results: -------------------------- After running #2: Nov 19 13:47:32 PM_SC-180 amf_demo[7495]: Terminating Nov 19 13:47:33 PM_SC-180 amf_demo_script: Instantiate called instantiate1 ................... Nov 19 13:47:33 PM_SC-180 amf_demo[7588]: 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' started Nov 19 13:47:33 PM_SC-180 amf_demo[7588]: Registered with AMF Nov 19 13:47:33 PM_SC-180 amf_demo[7588]: CSI Set - add 'safCsi=AmfDemo,safSi=AmfDemo,safApp=AmfDemo1' HAState Active Nov 19 13:47:45 PM_SC-180 osafamfnd[7282]: NO Admin restart requested for 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' Step #3: Nov 19 13:47:58 PM_SC-180 osafamfnd[7282]: NO 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' faulted due to 'avaDown' : Recovery is 'componentRestart' Nov 19 13:47:58 PM_SC-180 amf_demo_script: Cleanup called cleanup1 ................... Nov 19 13:47:58 PM_SC-180 amf_demo_script: Instantiate called instantiate1 ................... Nov 19 13:47:58 PM_SC-180 amf_demo[7674]: 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' started Nov 19 13:47:58 PM_SC-180 amf_demo[7674]: Registered with AMF Nov 19 13:47:58 PM_SC-180 amf_demo[7674]: CSI Set - add 'safCsi=AmfDemo,safSi=AmfDemo,safApp=AmfDemo1' HAState Active Step #5: After step#2 Nov 19 13:59:28 PM_SC-180 osafamfnd[9507]: NO Admin restart requested for 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' Nov 19 13:59:28 PM_SC-180 amf_demo_script: Term called term ................... Nov 19 13:59:28 PM_SC-180 amf_demo[9856]: exiting (caught term signal) Nov 19 13:59:28 PM_SC-180 amf_demo_script: Instantiate called instantiate1 ................... Nov 19 13:59:28 PM_SC-180 amf_demo[9905]: 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' started Nov 19 13:59:28 PM_SC-180 amf_demo[9905]: saAmfComponentRegister FAILED, But Continueing 20 Nov 19 13:59:28 PM_SC-180 amf_demo[9905]: Registered with AMF Conditions of Submission: ------------------------- Ack from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel