Hi all, Any comment on this ? Long-time pending, huh.... Thanks -Nagu
-----Original Message----- From: Nagendra Kumar Sent: 20 November 2013 15:23 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Mathivanan Naickan Palanivelu Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0 of 1] Review Request for amfnd: Reboot payload when link between Controller and Payload flickers [#600] Summary: amfnd: Reboot payload when link between Controller and Payload flickers [#600] Review request for Trac Ticket(s): #600 Peer Reviewer(s): hans.fe...@ericsson.com, hans.nordeb...@ericsson.com, mathi.naic...@oracle.com Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset be6a7a288913b548dac28e16e8bc1c75f10bc2a2 Author: Nagendra Kumar<nagendr...@oracle.com> Date: Wed, 20 Nov 2013 15:19:00 +0530 amfnd: Reboot payload when link between Controller and Payload flickers [#600] If AvD Adest UP comes after AvD Down, this means that link has been reset between controller and payload. If data verify messages comes after AvD Adest down and then AvD Adest Up comes, this means that it is a case of contorller failover. This patch marks a flag when Amfnd receives AvD Adest Down and Reset the flag when it gets Data Verify message during failover. If AvD Adest UP comes after Data verify message, then Amfnd doesn;t take any action in this context. But if AvD Adest Up comes just after AvD Adest Down, then Amfnd reboots itself. We have solved the problem of link flickering between Act controller and Payload. Still problem of TIPC link flickering among controllers remains the concerns. During testing of this patch, we had seen problem in controllers and cluster reset. This patch doesn't solve the problem of cluster reset because of TIPC link flickering between the controllers. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/di.cc | 20 ++++++++++++++++++++ osaf/services/saf/amf/amfnd/evt.cc | 4 +++- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 1 + osaf/services/saf/amf/amfnd/include/avnd_evt.h | 1 + osaf/services/saf/amf/amfnd/mds.cc | 15 ++++++--------- osaf/services/saf/amf/amfnd/verify.cc | 2 ++ 6 files changed, 33 insertions(+), 10 deletions(-) Testing Commands: ----------------- Reset the link between Act controller and payload. Testing, Expected Results: -------------------------- Payload should reboot. Conditions of Submission: ------------------------- Time out after 3 days. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel