Ack. Thanks, Praveen On 14-Nov-13 5:11 PM, nagendr...@oracle.com wrote: > Summary: amfd: Reject admin op if csi add/remove is in progress [#627] > Review request for Trac Ticket(s): #627 > Peer Reviewer(s): Hans F, Hans N > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): All > Development branch: 4.3.x > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset ce1ede2aa0d1954e885e5a471ab8355a7ee4512f > Author: Nagendra Kumar<nagendr...@oracle.com> > Date: Thu, 14 Nov 2013 17:08:09 +0530 > > amfd: Reject admin op if csi add/remove is in progress [#627] > > > Complete diffstat: > ------------------ > osaf/services/saf/avsv/avd/avd_csi.c | 18 ++++++++++++++++++ > osaf/services/saf/avsv/avd/avd_sg.c | 7 +++++++ > osaf/services/saf/avsv/avd/avd_si.c | 7 +++++++ > osaf/services/saf/avsv/avd/avd_su.c | 8 ++++++++ > osaf/services/saf/avsv/avd/include/avd_csi.h | 1 + > 5 files changed, 41 insertions(+), 0 deletions(-) > > > Testing Commands: > ----------------- > immcfg -d safCsi=AmfDemo1,safSi=AmfDemo,safApp=AmfDemo1 > amf-adm lock safSu=SU2\,safSg=AmfDemo\,safApp=AmfDemo1 > > > Testing, Expected Results: > -------------------------- > Lock command gets TRY again and when csi add succeeds, Admin commands is > honoured > > > Conditions of Submission: > ------------------------- > Ack from peer maintainers > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps > OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access > Free app hosting. Or install the open source package on any LAMP server. > Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native! > http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
