Ack with the comments I sent out in earlier mails. Good work, this code is in need of some clean-up and this is a step in the right direction!
regards, Anders Widell 2013-12-05 13:51, ramesh.bet...@oracle.com skrev: > Summary: Clean up unused code in "base" [#537] > Review request for Trac Ticket(s): 537 > Peer Reviewer(s): Mathi, Anders Widell > Pull request to: > Affected branch(es): default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system y > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries y > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > This patch deletes the unused/dead code to in "base". > > > changeset b0d56871186d8a97f2131f83fcf827048c107cd2 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:49:32 +0530 > > base: Deleted ncs_stack.h ncs_stack_pub.h hj_stack.c files[#537] > > changeset 7be2759a1023bf915aa10fcc0221cc9e889a28b0 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:51:54 +0530 > > base: Deleted ncsft.h file[#537] > > changeset dad744a421692549aa6dda5c72807fa30d04929a > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:52:50 +0530 > > base: Deleted sysf_pat.h file[#537] > > changeset 32a98ce45ccdfd89f8ed18c3b0a80f2a0908ca04 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:53:39 +0530 > > base: Removed unsed macro's from ncs_edu.h[#537] > > changeset bbb812476dd972c1cd03a056beeae960781b7a48 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:55:01 +0530 > > base: Removed MMGR macro's from ncs_hdl.h and replaced with > malloc,free[#537] > > changeset dfe1c3cc52c8c5cb368db69aaa6b7ef12c2ce9c4 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:55:57 +0530 > > base: Deleted ncs_tasks.h file [#537] > > changeset 4adaa1f162cf09f16fbfaa102f5be17f8c5a7e43 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:57:14 +0530 > > base: Deleted patricia.h file [#537] > > changeset 575febd3754e3e9b78551d3b2902968bd2146dfd > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:58:34 +0530 > > base: Deleted sysf_def.h file [#537] > > changeset 36ce1b7b5ca89857b22010c18254c46b82ec87de > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 17:59:30 +0530 > > base: Removed MMGR macro's from sysf_exc_scr.h and replaced with > malloc,free > [#537] > > changeset eb0f91da0b8c0c02d10e2fad1c970aaf73a8bdbd > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:00:25 +0530 > > base: Removed unused macros from sysf_ipc.h file. [#537] > > changeset 938d48afeb6ef045e1ec6b85abd3f7a3c0d70a20 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:01:12 +0530 > > base: Removed unused macros from ncs_osprm.h, ncssysf_def.h and > os_defs.h > files [#537] > > changeset dd2c02224b30ec10535027543cc430f2bbd86a29 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:02:05 +0530 > > base: Removed unused macros/structs from ncs_svd.h[#537] > > changeset cda006422f2ba7787c76ae86f4b6020df764131f > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:03:06 +0530 > > base: Removed unused macros from ncs_tmr.h [#537] > > changeset a48c1ceaccff9268bf829aa66631371053c98b9b > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:04:11 +0530 > > base: Removed unsued function definitions from usrbuf.h[#537] > > changeset 9e108ef0dafc4c302153f764a9a6f704acd50a88 > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:05:09 +0530 > > base: Deleted ncs_mds_def.h file[#537] > > changeset e9d5f2e96f1d1d775dff577ac346ea8daa08838a > Author: Ramesh <ramesh.bet...@oracle.com> > Date: Thu, 05 Dec 2013 18:06:16 +0530 > > base: Removed unsed functions from ncs_main_pub.h [#537] > > > Testing Commands: > ----------------- > Bring up two controllers, do switch-overs and failovers. > > Testing, Expected Results: > -------------------------- > Should succeed. > > Conditions of Submission: > ------------------------- > Ack from Mathi. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > Sponsored by Intel(R) XDK > Develop, test and display web and hybrid apps with a single code base. > Download it for free now! > http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
