Summary: AMF: allow change of nodegroup in SG
Review request for Trac Ticket(s): 569
Peer Reviewer(s): Nags
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 9b8cfdd772e0c36317fc97e2e623c5c4c896abf4
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 09 Dec 2013 13:45:52 +0100
amfd: white space changes [#569]
No functional changes. Just variable rename and some shorter lines in
sg.cc
changeset 9c4c321937a31cfa763ccd14082d06a553c63b92
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 09 Dec 2013 14:56:48 +0100
amfd: allow change of sg node group [#569]
The SG configuration attribute saAmfSGSuHostNodeGroup cannot be
changed. If
an application starts off with a node group such as "SCs" it cannot get
out
of it without complex model changes.
The validation in sg.cc by design disallow the change.
In this patch the validation is changed to allow change of node group to
another group that is a superset of the old one.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/sg.cc | 157
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------
1 files changed, 126 insertions(+), 31 deletions(-)
Testing Commands:
-----------------
1) Change nodegroup for some SG to a subset of the old one
2) Change nodegroup for some SG to a superset of the old one
Testing, Expected Results:
--------------------------
1) NOK
2) OK
Conditions of Submission:
-------------------------
Ack from Nags
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y Ubuntu something
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
