Hi Mathi, OpenSAF fails to compile after pushing the patch #219.
CC clmtest-tet_saClmResponse.o ../../tests/clmsv/src/tet_saClmResponse.c: In function 'saClmResponse_01': ../../tests/clmsv/src/tet_saClmResponse.c:94:13: error: variable 'ret' set but not used [-Werror=unused-but-set-variable] ../../tests/clmsv/src/tet_saClmResponse.c: In function 'saClmResponse_02': ../../tests/clmsv/src/tet_saClmResponse.c:134:13: error: variable 'ret' set but not used [-Werror=unused-but-set-variable] ../../tests/clmsv/src/tet_saClmResponse.c: In function 'saClmResponse_03': ../../tests/clmsv/src/tet_saClmResponse.c:175:13: error: variable 'ret' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make[2]: *** [clmtest-tet_saClmResponse.o] Error 1 Best regards, Zoran -----Original Message----- From: mathi.naic...@oracle.com [mailto:mathi.naic...@oracle.com] Sent: den 30 december 2013 13:56 To: ramesh.bet...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0 of 1] Review Request for clm: fix test suites [#219] Summary: clm: fix test suites [#219] Review request for Trac Ticket(s): #219 Peer Reviewer(s): Ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development branch: <<IF ANY GIVE THE REPO URL>> -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch attempts a stab at fixing the CLM test suites. changeset 8c074b46a75594e2b64a74ab71839b8c725e4dcd Author: Mathivanan N.P.<mathi.naic...@oracle.com> Date: Mon, 30 Dec 2013 18:22:04 +0530 clm: fix test suites [#219] Test suites 7 and 9, even though can be run manually, it is not guaranteed to succeed always because it involves admin operations on CLM nodes and by default it works on PL-3. 9 would require manual run in parallel with admin operations. This is just a first stab Complete diffstat: ------------------ tests/clmsv/src/tet_ClmOiOps.c | 12 ++++++------ tests/clmsv/src/tet_saClmClusterNodeGet.c | 31 ++++++++++++------------------- tests/clmsv/src/tet_saClmClusterNodeGetAsync.c | 4 ++-- tests/clmsv/src/tet_saClmClusterNotificationFree.c | 2 +- tests/clmsv/src/tet_saClmClusterTrack.c | 52 +++++++++++++++++++++++++++++++++++----------------- tests/clmsv/src/tet_saClmClusterTrackStop.c | 4 ++-- tests/clmsv/src/tet_saClmResponse.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------- 7 files changed, 140 insertions(+), 56 deletions(-) Testing Commands: ----------------- ./clmtest 1 ... 10 Testing, Expected Results: -------------------------- Except one or two, the rest of them should pass. Conditions of Submission: ------------------------- Ack from Ramesh or timeout on thursday. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
