> -----Original Message----- > From: Hans Feldt [mailto:hans.fe...@ericsson.com] > Sent: Thursday, January 09, 2014 5:38 PM > To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] [PATCH 0 of 4] Review Request for clm: Add CLMNA as a > component and support node eviction after opensafd stop [#220] > > One question, should the new CLMNA component be terminated by amfnd > or ignore the cleanup and get killed by the init script a bit like dtmd? > [Mathi] CLMNA being a component must be killed by AMFND during 'opensafd stop' The CLM server shall mark a node as "non-member" upon receiving AMFND down Event on a node on which 'opensafd stop' is being done.
> If killed by amfnd can it introduce a failover race problem of some kind? [Mathi] No, FM shall act on AMFND down to perform failover and AMFND being the last guy to exit. Mathi. > > Thanks, > Hans > > On 12/04/2013 02:00 PM, mathi.naic...@oracle.com wrote: > > Summary: Add CLMNA as a component, evict a node after 'opensafd stop' > > [#220] Review request for Trac Ticket(s): #220 Peer Reviewer(s): > > Ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > > Affected branch(es): default Development branch: <<IF ANY GIVE THE > > REPO URL>> > > > > -------------------------------- > > Impacted area Impact y/n > > -------------------------------- > > Docs n > > Build system n > > RPM/packaging n > > Configuration files n > > Startup scripts n > > SAF services y > > OpenSAF services y > > Core libraries n > > Samples n > > Tests n > > Other n > > > > > > Comments (indicate scope for each "y" above): > > --------------------------------------------- > > This patch adds CLMNA as a component to the NoRedundancy middleware > SU > > with recovery as node failfast! > > CLM Server shall treat CLMNA down as an additional evidence to > > indicate that the can now be marked as 'left the cluster'. > > On controllers, FM shall subscribe to AMFND down. During an OpenSAF > > stop, when AMFND exits (at last), then FM receives this DOWN and shall > > perform controller failover. For users who have set > > OPENSAF_MANAGE_TIPC=no, when they do a /etc/init.d/opensafd stop, > then > > the node will leave the cluster even if TIPC is running. > > > > TODO: > > - The patch works, however some testing is inprogress (i.e. dynamic > addition > > to informaiton model is pending). > > - condition to restrict this behaviour only when PLM is disabled to be > added. > > - provide a cli tool like 'clm-list' that lists the status of nodes in > > the cluster. > > > > changeset 00db20213aed87af57cb62940e38334d262d96fd > > Author: Mathivanan N.P.<mathi.naic...@oracle.com> > > Date: Wed, 04 Dec 2013 18:19:37 +0530 > > > > clm: add to the information model and update config, scripts [#220] > > > > changeset 8f93e72faea5f0dbeae073fb5868245db38b23f4 > > Author: Mathivanan N.P.<mathi.naic...@oracle.com> > > Date: Wed, 04 Dec 2013 18:20:15 +0530 > > > > clm: process clmna down at the clm server[#220] > > > > changeset 84e4801c4bf5aa036c94a0c6844e9476fd0b32ba > > Author: Mathivanan N.P.<mathi.naic...@oracle.com> > > Date: Wed, 04 Dec 2013 18:20:40 +0530 > > > > clm: register with amf [#220] > > > > changeset 858af6ff6a26d9f6fef5df54375febb2b82d8e13 > > Author: Mathivanan N.P.<mathi.naic...@oracle.com> > > Date: Wed, 04 Dec 2013 18:25:12 +0530 > > > > fm: trigger failover upon receiving AMFND down [#220] > > > > > > Added Files: > > ------------ > > osaf/services/saf/clmsv/config/clmna.conf > > > > > > Complete diffstat: > > ------------------ > > opensaf.spec.in | 1 + > > osaf/services/infrastructure/fm/fms/fm_mds.c | 33 > ++++++++++++++++++++++++++------- > > osaf/services/saf/clmsv/clms/clms_evt.c | 3 +++ > > osaf/services/saf/clmsv/clms/clms_evt.h | 1 + > > osaf/services/saf/clmsv/clms/clms_mds.c | 18 > > ++++++++++------ > -- > > osaf/services/saf/clmsv/config/Makefile.am | 3 ++- > > osaf/services/saf/clmsv/config/clmna.conf | 14 > > ++++++++++++++ > > osaf/services/saf/clmsv/config/clmsv_objects.xml | 85 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++ > > osaf/services/saf/clmsv/config/clmsv_plm_sc_template.xml | 17 > +++++++++++++++++ > > osaf/services/saf/clmsv/config/clmsv_sc_template.xml | 17 > +++++++++++++++++ > > osaf/services/saf/clmsv/nodeagent/Makefile.am | 14 > +++++++++++--- > > osaf/services/saf/clmsv/nodeagent/scripts/osaf-noded.in | 21 > +++++++++++++++++++++ > > 12 files changed, 208 insertions(+), 19 deletions(-) > > > > > > Testing Commands: > > ----------------- > > > > 1) Set OPENSAF_MANAGE_TIPC=no, and do /etc/init.d/opensafd stop on a > > payload node, do a immlist of that node, the node should have been > marked as left. > > 2) Repeat above with OPENSAF_MANAGE_TIPC=yes. Results same as > above. > > 3) Repeat 1) and 2) and ACTIVE controller. Result: Controller failover > > 4) Repeat3) on standby controller. immlist for standby controller > > should indicate that the node has left the cluster. > > > > Testing, Expected Results: > > -------------------------- > > Same as above. > > > > Conditions of Submission: > > ------------------------- > > Ack from Ramesh Or A week from now(by that time, will publish a latest > version). > > > > Arch Built Started Linux distro > > ------------------------------------------- > > mips n n > > mips64 n n > > x86 n n > > x86_64 y y > > powerpc n n > > powerpc64 n n > > > > > > Reviewer Checklist: > > ------------------- > > [Submitters: make sure that your review doesn't trigger any > > checkmarks!] > > > > > > Your checkin has not passed review because (see checked entries): > > > > ___ Your RR template is generally incomplete; it has too many blank entries > > that need proper data filled in. > > > > ___ You have failed to nominate the proper persons for review and push. > > > > ___ Your patches do not have proper short+long header > > > > ___ You have grammar/spelling in your header that is unacceptable. > > > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > > > ___ You have incorrectly put/left internal data in your comments/files > > (i.e. internal bug tracking tool IDs, product names etc) > > > > ___ You have not given any evidence of testing beyond basic build tests. > > Demonstrate some level of runtime or other sanity testing. > > > > ___ You have ^M present in some of your files. These have to be removed. > > > > ___ You have needlessly changed whitespace or added whitespace crimes > > like trailing spaces, or spaces before tabs. > > > > ___ You have mixed real technical changes with whitespace and other > > cosmetic code cleanup changes. These have to be separate commits. > > > > ___ You need to refactor your submission into logical chunks; there is > > too much content into a single commit. > > > > ___ You have extraneous garbage in your review (merge commits etc) > > > > ___ You have giant attachments which should never have been sent; > > Instead you should place your content in a public tree to be pulled. > > > > ___ You have too many commits attached to an e-mail; resend as threaded > > commits, or place in a public tree for a pull. > > > > ___ You have resent this content multiple times without a clear indication > > of what has changed between each re-send. > > > > ___ You have failed to adequately and individually address all of the > > comments and change requests that were proposed in the initial review. > > > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > > > ___ Your computer have a badly configured date and time; confusing the > > the threaded patch review. > > > > ___ Your changes affect IPC mechanism, and you don't present any results > > for in-service upgradability test. > > > > ___ Your changes affect user manual and documentation, your patch series > > do not contain the patch that updates the Doxygen manual. > > > > > > ---------------------------------------------------------------------- > > -------- > > Sponsored by Intel(R) XDK > > Develop, test and display web and hybrid apps with a single code base. > > Download it for free now! > > > http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg. > > clktrk _______________________________________________ > > Opensaf-devel mailing list > > Opensaf-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > > > ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
