Any feedback? I would like to push asap. /Hans On 01/28/2014 02:41 PM, Hans Feldt wrote: > Summary: AMF #662 v2 > Review request for Trac Ticket(s): 662 > Peer Reviewer(s): Nags > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): 4.4 & default > Development branch: 4.4 > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > Version 2 of the patches after comments by Nags. Not incorporated is the > change > that would be backwards incompatible. Some really nice code simplification was > achieved using a common function. Complexity numbers decreased. > > changeset c2385377f99d2ff4b710ecfc36861cc882e95b36 > Author: Hans Feldt <[email protected]> > Date: Tue, 28 Jan 2014 14:29:38 +0100 > > amfd: require saAmfCtSwBundle when relpath in CLC-CLI cmds [#662] > > changeset 402e4d387034a4f72ebe9b6ba2a8d760af6039a4 > Author: Hans Feldt <[email protected]> > Date: Tue, 28 Jan 2014 14:33:33 +0100 > > amfnd: ignore saAmfCtSwBundle when abspath in CLC-CLI cmds [#662] > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/amfd/comptype.cc | 147 > ++++++++++++++++++++++++++++++++++++++++++++++----------------- > osaf/services/saf/amf/amfnd/compdb.cc | 290 > +++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------- > 2 files changed, 215 insertions(+), 222 deletions(-) > > > Testing Commands: > ----------------- > Start single node cluster > Add appconfig.xml with all types of commands, configure cmd and argv in type > and argv in comp instance > some with relpath some with abspath > (appconfig.xml attached to ticket) > > > Testing, Expected Results: > -------------------------- > from amfnd trace: > > Jan 28 14:28:34.944887 osafamfnd [4569:compdb.cc:1214] TR > cmd=/home/hasse/test/amf-601/amf_demo_script instantiate dummy > Jan 28 14:28:34.944907 osafamfnd [4569:compdb.cc:1214] TR > cmd=/home/hasse/test/amf-601/amf_demo_script terminate dummy-cleanup > Jan 28 14:28:34.944928 osafamfnd [4569:compdb.cc:1214] TR > cmd=/home/hasse/test/amf-601/amf_demo_script cleanup dummy-cleanup > Jan 28 14:28:34.944957 osafamfnd [4569:compdb.cc:1214] TR cmd=/bin/true > amstart dummy-amstart > Jan 28 14:28:34.944978 osafamfnd [4569:compdb.cc:1214] TR cmd=/bin/true > amstop dummy-amstop > Jan 28 14:28:34.945000 osafamfnd [4569:compdb.cc:1214] TR cmd=/bin/true > status dummy-osafhc > > > > Conditions of Submission: > ------------------------- > Ack from Nags > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y ubuntu13.10 > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > WatchGuard Dimension instantly turns raw network data into actionable > security intelligence. It gives you real-time visual feedback on key > security issues and trends. Skip the complicated setup - simply import > a virtual appliance and go from zero to informed in seconds. > http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > >
------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
