Summary: amfnd : handle successful cleanup of assigned comp gracefully in shutdown phase [#767] Review request for Trac Ticket(s):AMF #767 Peer Reviewer(s): Hans F., Hans N., Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es):All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Please see the commit log below. changeset c1e26e6c161e7567498c6a2b193ae3b128802af1 Author: [email protected] Date: Tue, 04 Feb 2014 15:02:06 +0530 amfnd : handle successful cleanup of assigned comp gracefully in shutdown phase [#767] During opensaf shutdown AMFND removes the SIs from the SUs in the reverse order of their ranks. At component level this gets translated as giving csi removal callback to the components with TARGET_ONE. Reported problem occurs when an assigned component faults while removal is going on other components. When AMFND gets cleanup success event, it sees it as if the component was faulted while handling removal callback and thus it tries to move CSIs and SIs assigned to this component to removed state. Since CSIs and SIs were already in assigned state AMFND asserts for assigning state check. This patch ensures that during shutdown phase if an assigned component faults then AMFND should mark CSIs and SIs assigned if they were in assigning state. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-) Testing Commands: ----------------- Tested as per ticket description using the configuration attached in the ticket. Testing, Expected Results: -------------------------- No amfnd assert. Conditions of Submission: ------------------------- Ack from atleast one reviewer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
