Ack with comments.
1) It is probably a good idea to validate that role is within bounds
before accessing the array with strings role_string[role]. It could be
done e.g. in the following way:
LOG_NO("RDE role set to %s", role >= 0 && role < sizeof(role_string) /
sizeof(role_string[0]) ? role_string[role] : "?");
2) Shouldn't the strings match the enum values? The PCS_RDA_ROLE enum
has the following definition:
typedef enum {
PCS_RDA_UNDEFINED = 0,
PCS_RDA_ACTIVE,
PCS_RDA_STANDBY,
PCS_RDA_QUIESCED,
PCS_RDA_ASSERTING,
PCS_RDA_YIELDING
} PCS_RDA_ROLE;
/ Anders W
2014-02-19 02:43, mathi.naic...@oracle.com skrev:
> Summary: rde: print controller role as string and refine log messages [#63]
> Review request for Trac Ticket(s): #63
> Peer Reviewer(s): anders.wid...@ericsson.com
> Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
> Affected branch(es): opensaf-4.2.x, 4.3.x, 4.x, default
> Development branch: <<IF ANY GIVE THE REPO URL>>
>
> --------------------------------
> Impacted area Impact y/n
> --------------------------------
> Docs n
> Build system n
> RPM/packaging n
> Configuration files n
> Startup scripts n
> SAF services n
> OpenSAF services y
> Core libraries n
> Samples n
> Tests n
> Other n
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
> RDE currently prints the role as numbers. This is difficult
> to understand.
> Also, initial startup and role changes, the current log
> message can be improved.
>
> changeset c63500ec07ac08b87235d00b7ffe1d4b0d0eb9aa
> Author: Mathivanan N.P.<mathi.naic...@oracle.com>
> Date: Tue, 18 Feb 2014 20:39:18 -0500
>
> rde: print controller role as string and refine log messages [#63]
>
>
> Complete diffstat:
> ------------------
> osaf/services/infrastructure/rde/rde_main.c | 24 +++++++++++++++++-------
> 1 files changed, 17 insertions(+), 7 deletions(-)
>
>
> Testing Commands:
> -----------------
> - Note the roles getting printed as strings instead of numbers.
> - The log string during initial startup, switchover, failover should
> look more understandable.
>
>
> Testing, Expected Results:
> --------------------------
> - Note the roles getting printed as strings instead of numbers.
> - The log string during initial startup, switchover, failover should
> look more understandable.
>
> Conditions of Submission:
> -------------------------
> Ack from Anders.
>
> Arch Built Started Linux distro
> -------------------------------------------
> mips n n
> mips64 n n
> x86 n n
> x86_64 y y
> powerpc n n
> powerpc64 n n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
> that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
> (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
> Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
> like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
> cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
> too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
> Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
> commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
> of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
> comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
> the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
> for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
> do not contain the patch that updates the Doxygen manual.
>
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
