Ack

Thanks
-Nagu

> -----Original Message-----
> From: Praveen Malviya
> Sent: 26 February 2014 17:50
> To: [email protected]; Nagendra Kumar
> Cc: [email protected]
> Subject: [PATCH 1 of 1] amfd : fix avnd down event of standby controller 
> [#797]
> 
>  osaf/services/saf/avsv/avd/avd_sgproc.c |  31 ++++++++++++++++---------------
>  1 files changed, 16 insertions(+), 15 deletions(-)
> 
> 
> When standby controller is stopped active controller will get avnd down event.
> In this event AMF will perform failover of all the SUs hosted on the standby
> controller.
> The problem occurred because AMFD is trying to access SUSI in NULL poiner in
> avnd list of SU.
> This patch avoid accessing SUSI list if SU pointer is NULL
> 
> diff --git a/osaf/services/saf/avsv/avd/avd_sgproc.c
> b/osaf/services/saf/avsv/avd/avd_sgproc.c
> --- a/osaf/services/saf/avsv/avd/avd_sgproc.c
> +++ b/osaf/services/saf/avsv/avd/avd_sgproc.c
> @@ -2185,22 +2185,23 @@ void avd_node_down_appl_susi_failover(AV
>       if (cb->init_state == AVD_APP_STATE) {
>               i_su = avnd->list_of_su;
> 
> -             /* Unlike active, quiesced and standby HA states, assignment
> counters
> -                in quiescing HA state are updated when AMFD receives
> assignment
> -                response from AMFND. During nodefailover amfd will not
> receive
> -                assignment response from AMFND.
> -                So if any SU is under going modify operation then update
> assignment
> -                counters for those SUSIs which are in quiescing state in the
> SU.
> -              */
> -             AVD_SU_SI_REL *susi;
> -             for (susi = i_su->list_of_susi; susi; susi = susi->su_next) {
> -                     if ((susi->fsm == AVD_SU_SI_STATE_MODIFY) &&
> -                                     (susi->state ==
> SA_AMF_HA_QUIESCING)) {
> -                             avd_susi_update_assignment_counters(susi,
> AVSV_SUSI_ACT_MOD,
> -                                             SA_AMF_HA_QUIESCING,
> SA_AMF_HA_QUIESCED);
> +             while (i_su != NULL) {
> +
> +                     /* Unlike active, quiesced and standby HA states,
> assignment counters
> +                        in quiescing HA state are updated when AMFD
> receives assignment
> +                        response from AMFND. During nodefailover amfd will
> not receive
> +                        assignment response from AMFND.
> +                        So if any SU is under going modify operation then
> update assignment
> +                        counters for those SUSIs which are in quiescing state
> in the SU.
> +                      */
> +                     AVD_SU_SI_REL *susi;
> +                     for (susi = i_su->list_of_susi; susi; susi = 
> susi->su_next) {
> +                             if ((susi->fsm == AVD_SU_SI_STATE_MODIFY)
> &&
> +                                             (susi->state ==
> SA_AMF_HA_QUIESCING)) {
> +
>       avd_susi_update_assignment_counters(susi, AVSV_SUSI_ACT_MOD,
> +
>       SA_AMF_HA_QUIESCING, SA_AMF_HA_QUIESCED);
> +                             }
>                       }
> -             }
> -             while (i_su != NULL) {
>                       switch (i_su->sg_of_su->sg_redundancy_model) {
>                       case SA_AMF_2N_REDUNDANCY_MODEL:
>                               /* Now analyze the service group for the new
> HA state

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to