Summary: amfnd: fix failover of NPI SU during SU lock with fault [#820] Review request for Trac Ticket(s): AMF #820 Peer Reviewer(s): Hans F., Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Please see the ticket and commit log below. changeset d9da58fe613ef6bc72fee9d2531d499cccc11508 Author: [email protected] Date: Wed, 26 Mar 2014 10:38:31 +0530 amfnd: fix failover of NPI SU during SU lock with fault [#820] Problem: During lock of NPI SU, AMF does not failover assignments if a healthy component faults. Reason: During SU lock AMF sends quiesced assignment to NPI SU. During quiesced assignment, when termination of one component is in progress, one of the healthy components faults. AMF performs cleanup of this failed component and it moves the SU from TERMINATING to UNINSTANTIATED state without waiting for the terminate command response of the first component. Thus SU moves to UNINSTANTIATED state when one of the components is still in TERMINATING state. Now when first component responds for the terminate command, AMF sees SU in UNINSTANTIATED state and it does not take any action. Fix: AMF should move NPI SU in UNINSTANTIATED state only when all the CSIs are moved to Removed/Assigned state. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/comp.cc | 2 +- osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 + osaf/services/saf/amf/amfnd/susm.cc | 34 +++++++++++++++++++++++++++++++--- 3 files changed, 33 insertions(+), 4 deletions(-) Testing Commands: ----------------- Tested as per ticket description. Some other tests will be run during review phase. Testing, Expected Results: -------------------------- Passed. AMF performed failover successfully. Conditions of Submission: ------------------------- Ack from atleast one reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
