Summary: Suuport for saImmOmCcbAbort and saImmOmCcbValidate [#798]
Review request for Trac Ticket(s): 798
Peer Reviewer(s): Neel, Zoran
Pull request to:
Affected branch(es): default(4.5)
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset ff59c42247565fced4bfc0deb8a91ddad829dbd5
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Fri, 04 Apr 2014 12:26:08 +0200
IMM: Support for saImmOmCcbAbort API [#798]
See ticket or osaf/services/saf/immsv/README for details.
changeset 8e505607f59087da04f0763da8a9fa6984a47e0d
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Fri, 04 Apr 2014 13:38:40 +0200
IMM: Support for saImmOmCcbValidate API [#798]
See ticket or osaf/services/saf/immsv/README for details.
changeset bb703c2dae5144531c1006f0439d8236ab07f0f8
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Fri, 04 Apr 2014 14:43:52 +0200
IMM: README update for saImmOmCcbAbort and saImmOmCcbValidate [#798]
Added Files:
------------
osaf/libs/saf/include/saImmOm_A_2_14.h
Complete diffstat:
------------------
osaf/libs/agents/saf/imma/imma_cb.h | 2 +
osaf/libs/agents/saf/imma/imma_def.h | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 11 +-
osaf/libs/agents/saf/imma/imma_om_api.c | 244
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
osaf/libs/common/immsv/immsv_evt.c | 4 +
osaf/libs/common/immsv/include/immsv_evt.h | 1 +
osaf/libs/saf/include/saImmOm_A_2_13.h | 2 +
osaf/libs/saf/include/saImmOm_A_2_14.h | 49 ++++++++++++
osaf/services/saf/immsv/README | 88
++++++++++++++++++++++
osaf/services/saf/immsv/immnd/ImmModel.cc | 167
++++++++++++++++++++++++++++++++++--------
osaf/services/saf/immsv/immnd/ImmModel.hh | 3 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 73
+++++++++++++++---
osaf/services/saf/immsv/immnd/immnd_init.h | 4 +-
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/test_SaImmOiCcb.c | 120
++++++++++++++++++++++++++++-
tests/immsv/implementer/test_saImmOiAugmentCcbInitialize.c | 38 ++++++++-
tests/immsv/management/test_saImmOmCcbApply.c | 184
++++++++++++++++++++++++++++++++++++++++++++++
tests/immsv/management/test_saImmOmCcbInitialize.c | 8 ++
tests/unit_test_fw/src/utest.c | 2 +-
19 files changed, 924 insertions(+), 82 deletions(-)
Testing Commands:
-----------------
Some test cases have been added to immomtest and immoitest
that excercise these two new API calls.
Testing, Expected Results:
--------------------------
The new APIs should work as exxpected and not interfere with any
existing functionality.
Conditions of Submission:
-------------------------
Ack from Neel.
Zoran, please also review this one.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
