Hi zoran, when we dump to a db eg: immdump -p /tmp/dump.db
and try to open the db, you still see the precession is not followed(same with PBE). #sqlite3 /tmp/dump.db .dump > /tmp/dump.sql Eg: # immlist testClass=1 Name Type Value(s) ======================================================================== testClass SA_STRING_T testClass=1 fattr SA_FLOAT_T 3.1415927 dattr SA_DOUBLE_T 3.1415927410125732 SaImmAttrImplementerName SA_STRING_T <Empty> SaImmAttrClassName SA_STRING_T TestClass SaImmAttrAdminOwnerName SA_STRING_T IMMLOADER where as in db it is: INSERT INTO "TestClass" VALUES(354,'testClass=1',3.14159274101257,3.14159274101257,NULL,'TestClass','IMMLOADER'); This may not have impact, but the precision is not followed. /Neel. On Wednesday 09 April 2014 04:30 PM, Zoran Milinkovic wrote: > Hi Neelakanta, > > Can you be more specific where the precision is not followed ? > There is no need for another ticket. We can fix it in this ticket. > > Best regards, > Zoran > > -----Original Message----- > From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] > Sent: den 9 april 2014 12:46 > To: Zoran Milinkovic > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 0 of 1] Review Request for IMMTOOLS: fix printing and > dumping for float and double values [#53] > > Hi Zoran, > > Reviewed and tested the patch. > Ack. > > The published patch, work fine when dumping for float and double is for xml > format. > > where as either in PBE or in dumpcase the precision is not yet followed > (probably a new ticket may be created for fixing at later stage) > > /Neel. > > > > On Tuesday 25 March 2014 06:29 PM, Zoran Milinkovic wrote: >> Summary: IMMTOOLS: fix printing and dumping for float and double >> values [#53] Review request for Trac Ticket(s): 53 Peer Reviewer(s): >> Neelakanta Pull request to: Zoran Affected branch(es): default(4.5) >> Development branch: default(4.5) >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset 2421ad9733ede8656aacf1f94d4b5ae70cf6b156 >> Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> >> Date: Tue, 25 Mar 2014 11:11:51 +0100 >> >> IMMTOOLS: fix printing and dumping for float and double values [#53] >> >> >> Complete diffstat: >> ------------------ >> osaf/libs/common/immsv/immpbe_dump.cc | 2 ++ >> osaf/tools/safimm/immlist/imm_list.c | 8 ++++---- >> 2 files changed, 6 insertions(+), 4 deletions(-) >> >> >> Testing Commands: >> ----------------- >> immdump test.xml >> immlist <DN> >> >> >> Testing, Expected Results: >> -------------------------- >> immdump must export big float and double values in a scientific format >> (including exponent). >> immlist must print big float and double values in a scientific format. >> immload must import big float and double values from XML file dumped by >> immdump. The precision should not be lost. >> >> >> Conditions of Submission: >> ------------------------- >> Ack from Neelakanta >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any >> checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
