Summary: Introduce and use AMF SU methods
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans N, Praveen, Nags
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
More similar changes are needed to complete the SU class change work. All
functions taking an SU ptr as first argument should be converted to methods.
changeset 95d342e7c56cd136399dc7ebd96750ea676e69e3
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 10 Apr 2014 14:47:47 +0200
amfd: change AVD_SU from struct to class [#713]
First change in series to convert all functions operating on SU data
into
methods. No functional impact.
changeset ef4e7c56f9eb75f45795d3f16b79d0a394bfb0cc
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 10 Apr 2014 14:47:48 +0200
amfd: add and use SU method oper_state_set [#713]
Change function avd_su_oper_state_set into a method, use it and remove
the
old function.
changeset 02270d005425264d46010cf59c31cb3ad7acd62f
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 10 Apr 2014 14:47:48 +0200
amfd: add SU susi manipulation methods [#713]
same functionality as function avd_sg_su_asgn_del_util but split into
three
SU methods instead.
changeset df5dbd67fc4e1db86e7d927496803eb2c54bcbe9
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 10 Apr 2014 14:47:49 +0200
amfd: use SU method delete_all_susis [#713]
changeset cb0c337f64ce7c17c93b1f55ab0c459ef1815cdd
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 10 Apr 2014 14:47:49 +0200
amfd: use SU methods for changing susis [#713]
avd_sg_su_asgn_del_util is removed
changeset 62ffd7807d5ad1b36e4cde7e66ac3e590811eba8
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 10 Apr 2014 14:47:50 +0200
amfd: add and use SU method readiness_state_set [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/include/comp.h | 8 +++++---
osaf/services/saf/amf/amfd/include/node.h | 9 +++++----
osaf/services/saf/amf/amfd/include/proc.h | 1 -
osaf/services/saf/amf/amfd/include/sg.h | 28
+++++++++++++++-------------
osaf/services/saf/amf/amfd/include/si_dep.h | 12 ++++++------
osaf/services/saf/amf/amfd/include/su.h | 20 ++++++++++++--------
osaf/services/saf/amf/amfd/include/sutype.h | 6 +++---
osaf/services/saf/amf/amfd/include/util.h | 8 +++++---
osaf/services/saf/amf/amfd/ndfsm.cc | 2 +-
osaf/services/saf/amf/amfd/ndproc.cc | 2 +-
osaf/services/saf/amf/amfd/node.cc | 4 ++--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 82
+++++++++++++++++++++++++++++++++++++++++-----------------------------------------
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 56
++++++++++++++++++++++++++++----------------------------
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 14 +++++++-------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 20 ++++++++++----------
osaf/services/saf/amf/amfd/sgproc.cc | 139
++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/su.cc | 137
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
17 files changed, 274 insertions(+), 274 deletions(-)
Testing Commands:
-----------------
Build and start opensaf
Testing, Expected Results:
--------------------------
starts fine
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y ubuntu13.10
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
