Hi Lennart,
I will update the document too, but what do you think of the following print?
Should we remove it?
} else {
LOG_NO("Too low LOGSV_MAX_LOGRECSIZE (%u), using default (%u)",
max_logrecsize, lgs_cb->max_logrecsize);
}
Thanks,
Mathi.
----- [email protected] wrote:
> osaf/libs/agents/saf/lga/lga_api.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
>
> There is a check in LGA as below:
> if (logFileCreateAttributes->maxLogRecordSize
> == 0) {
> TRACE(maxLogRecordSize);
> return SA_AIS_ERR_INVALID_PARAM;
> }
> This prevents applications from opening a stream with zero sized
> records.
> streamOpen() returns with error SA_AIS_ERR_INVALID_PARAM.
> Without this patch, $ saflogger -a dummy
> returns SA_AIS_ERR_INVALID_PARAM.
> With this patch, $ saflogger -a dummy
> works fine.
>
> diff --git a/osaf/libs/agents/saf/lga/lga_api.c
> b/osaf/libs/agents/saf/lga/lga_api.c
> --- a/osaf/libs/agents/saf/lga/lga_api.c
> +++ b/osaf/libs/agents/saf/lga/lga_api.c
> @@ -507,11 +507,6 @@ static SaAisErrorT validate_open_params(
> return SA_AIS_ERR_INVALID_PARAM;
> }
>
> - if (logFileCreateAttributes->maxLogRecordSize == 0) {
> - TRACE("maxLogRecordSize");
> - return SA_AIS_ERR_INVALID_PARAM;
> - }
> -
> if (logFileCreateAttributes->logFileFullAction <
> SA_LOG_FILE_FULL_ACTION_WRAP
> || logFileCreateAttributes->logFileFullAction >
> SA_LOG_FILE_FULL_ACTION_ROTATE) {
> TRACE("logFileFullAction");
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Opensaf-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
