Hi zoran, comments inline.
/Neel. ----- Original Message ----- From: zoran.milinko...@ericsson.com To: reddy.neelaka...@oracle.com, anders.bjornerst...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Sent: Friday, April 25, 2014 3:08:07 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi Subject: RE: [devel] [PATCH 0 of 1] Review Request for Imm:Make immcfg aware of safImmService admin owner for opensafImm=opensafImm, safApp=safImmService [#840] Hi Neelakanta, I have few comments to the patch: 1. Why did you disable enabling and disabling notifications in explicit commit mode ? In the transaction mode, if a ccb operations are not yet applied and if enabling and disabling of notification for the class which is the part of that ccb operation will abort that ccb. so, i thought It is better to disable enabling and disabling notifications in explicit commit mode. 2. strcpy() in line 788 is not safe. adminOwnerName may have less allocated bytes than "safImmService". For example: if an application change immcfg name into one byte name like "i". In this case allocated memory for adminOwnerName is less than "safImmService". You should either check the size of adminOwnerName and resize it if it's needed or simply use OPENSAF_IMM_SERVICE_NAME directly in immutil_saImmOmAdminOwnerInitialize() without coping "safImmService" into adminOwnerName. ok, will modify the patch accordingly. 3. Enabling and disabling notifications is not a transactional operation, so class_change function may initialize its own OM handle and admin owner handle. There is no need for using the same OM handle (which is used for CCBs) for enabling/disabling notifications. In this case, you don't need to change other functions. I agree that Enabling and disabling notifications is not a transactional operation, but i aligned to have only one OM handle. If we can have multiple OM handles, it is better to have a different utility for these, why do you want all operations in one utility? NACK from me for now. Best -----Original Message----- From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com] Sent: den 18 april 2014 15:25 To: Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0 of 1] Review Request for Imm:Make immcfg aware of safImmService admin owner for opensafImm=opensafImm, safApp=safImmService [#840] Summary:IMM :Make immcfg aware of safImmService admin owner for opensafImm=opensafImm,safApp=safImmService [#840] Review request for Trac Ticket(s): 840 Peer Reviewer(s): AndersBj, Zoran Affected branch(es): 4.4.x, default Development branch: default -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 38bdc703daf9ecd702ed9e12cb5740a52b0bc5c4 Author: Neelakanta Reddy<reddy.neelaka...@oracle.com> Date: Fri, 18 Apr 2014 18:48:42 +0530 Imm:Make immcfg aware of safImmService admin owner for opensafImm=opensafImm,safApp=safImmService [#840] enable or disable notififications using immcfg does not work on a system running 2PBE. In the 2PBE the IMM internal object opensafImm=opensafImm,safApp=safImmService has admin owner safImmService. To modify the IMM object the adminoner has to be set to safImmService. Testing Commands: ----------------- All the immcfg commands must work for 2PBE,1PBE, OPBE Testing, Expected Results: -------------------------- with this patch while testing in explicit commit mode (transaction mode) enable or disable notififications is not supported. And all other immcfg commands must work. Conditions of Submission: ------------------------- Ack from AndersBj and zoran Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel