Summary: log: Log should not retry when close() returns EINTR [#147]
Review request for Trac Ticket(s): 147
Peer Reviewer(s): Mathi/Lennart
Affected branch(es): 4.4.x; default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 92367fca8c8956c44e22e0838be89804970cdb35
Author: Ramesh <ramesh.bet...@oracle.com>
Date: Fri, 02 May 2014 12:29:58 +0530
log: Log should not retry when close() returns EINTR [#147] In case of
close(), the first thing Linux does is deallocate the file descriptor;
then
it starts flushing pending written data. If this process is
interrupted, it
will return EINTR, but the file descriptor itself is already
deallocated,
and may have been reused long before close() returned. Hence it is not
required to retry close().
Complete diffstat:
------------------
osaf/services/saf/logsv/lgs/lgs_filehdl.c | 4 ----
osaf/services/saf/logsv/lgs/lgs_stream.c | 2 +-
2 files changed, 1 insertions(+), 5 deletions(-)
Testing Commands:
-----------------
Difficult to reproduce.
Bring up OpenSAF, do switch-overs/fail-overs.. observe logging by LOGSv is
intact.
Testing, Expected Results:
--------------------------
Should not impact the sanity run of OpenSAF and logging by LOG svc.
Conditions of Submission:
-------------------------
Ack from Mathi/Lennart
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
