Ack from me. Tested. Did not re-review the code. /AndersBj
reddy.neelaka...@oracle.com wrote: > Summary:Imm:Make immcfg aware of safImmService admin owner for > opensafImm=opensafImm,safApp=safImmService [#840] > Review request for Trac Ticket(s): 840 > Peer Reviewer(s): AndersBj, Zoran > Affected branch(es):4.4.x, default > Development branch: default > > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > The patch also changes the function definition, for object_modify, > object_delete, object_create, class_change. The admin ownerhandle is > global so, no need to pass as argument. > > > changeset 2d54f73507f6c425372c3ae357bb67e07b947e11 > Author: Neelakanta Reddy<reddy.neelaka...@oracle.com> > Date: Thu, 01 May 2014 14:50:40 +0530 > > Imm:Make immcfg aware of safImmService admin owner for > opensafImm=opensafImm,safApp=safImmService [#840] Enable or Disable > notififications using immcfg does not work on a system running 2PBE. In > the > 2PBE the IMM internal object opensafImm=opensafImm,safApp=safImmService > has > admin owner safImmService. To modify the IMM object the adminoner has > to be > set to safImmService. > > > Complete diffstat: > ------------------ > osaf/tools/safimm/immcfg/imm_cfg.c | 44 > ++++++++++++++++++++++++++++++++------------ > 1 files changed, 32 insertions(+), 12 deletions(-) > > > Testing Commands: > ----------------- > All the immcfg commands must work for 2PBE,1PBE, OPBE > > Testing, Expected Results: > -------------------------- > with this patch enable or disable notififications in 2PBE should not fail > > Conditions of Submission: > ------------------------- > Ack from AndersBj and zoran > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
