Ack, minor comment you could change "is not" => "could not be" Thanks, Hans
> -----Original Message----- > From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] > Sent: den 7 maj 2014 10:37 > To: Hans Feldt; nagendr...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] amfd: syslog no assignment of SI when it is unlocked > [#867] > > osaf/services/saf/amf/amfd/si.cc | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > > Problem: A SI is unlocked and it is not assigned to any SU. User > does not have any clue for the outcome of admin operation. > > Reason: Reasons for unassignment can be many, AMF should log > that SI is not assigned. > > Fix: adding a log notice for unassignment of SI. > > diff --git a/osaf/services/saf/amf/amfd/si.cc > b/osaf/services/saf/amf/amfd/si.cc > --- a/osaf/services/saf/amf/amfd/si.cc > +++ b/osaf/services/saf/amf/amfd/si.cc > @@ -853,6 +853,9 @@ static void si_admin_op_cb(SaImmOiHandle > avd_si_admin_state_set(si, SA_AMF_ADMIN_UNLOCKED); > > err = si->sg_of_si->si_func(avd_cb, si); > + if (si->list_of_sisu == NULL) > + LOG_NO("'%s' is not assigned to any SU.", > si->name.value); > + > if (err != NCSCC_RC_SUCCESS) { > report_admin_op_error(immOiHandle, invocation, > SA_AIS_ERR_BAD_OPERATION, NULL, > "SI unlock of %s failed", > objectName->value); ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
