Summary: clm: pass client_id for deletion; post to mbox only when svc_id is filled [#888] Review request for Trac Ticket(s): #888 Peer Reviewer(s): ramesh.bet...@oracle.com Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): opensaf-4.3.x, opensaf-4.4.x, default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 291aea16fd89298a82ba54fd9e3fca15169ec939 Author: Mathivanan N.P.<mathi.naic...@oracle.com> Date: Fri, 16 May 2014 16:16:15 -0400 clm: pass client_id for deletion; post to mbox only when svc_id is filled [#888] Valgrind reported the following: ==9425== Invalid read of size 4 ==9425== at 0x40AAE2: clms_client_delete_by_mds_dest (clms_evt.c:167) ==9425== by 0x40AC50: proc_clma_updn_mds_msg (clms_evt.c:621) ==9425== by 0x40BB8F: clms_process_mbx (clms_evt.c:1307) ==9425== by 0x403FDD: main (clms_main.c:499) ==9425== Address 0x67ba190 is 32 bytes inside a block of size 64 free'd ==9425== at 0x4C2BDEC: free (in /usr/lib/valgrind /vgpreload_memcheck-amd64-linux.so) ==9425== by 0x40AA22: clms_client_delete (clms_evt.c:205) ==9425== by 0x40AAE1: clms_client_delete_by_mds_dest (clms_evt.c:164) ==9425== by 0x40AC50: proc_clma_updn_mds_msg (clms_evt.c:621) ==9425== by 0x40BB8F: clms_process_mbx (clms_evt.c:1307) ==9425== by 0x403FDD: main (clms_main.c:499) This warning from valgrind is shown in the context of the below lines: rc = clms_client_delete(client->client_id); /* Delete this client data from the clmresp tracking list */ rc = clms_client_del_trackresp(client->client_id); It can be seen that clms_client_del_trackresp was accessing a memory that would get freed in some flows by the previous line. The second part of the patch adds a check in clms_mds.c such that posting to mailbox is done only after explicitly checking whether the service id is for CLMA or AMFND. There is a subscription for CLMNA also, but we are not doing anything today for CLMNA down. So, in the case when CLMNA down comes, the event-type field is not getting set when posting to the mail box. This results in a situation where the mailbox processing invokes proc_initialize() because the event-type gets set to 0 which is the default value. Complete diffstat: ------------------ osaf/services/saf/clmsv/clms/clms_evt.c | 2 +- osaf/services/saf/clmsv/clms/clms_mds.c | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) Testing Commands: ----------------- STart a 5 node cluster. Perform controller failover. During failover, the log "NO proc_initialize_msg: send failed. dest:" should not be seen. No other issue should be seen. Testing, Expected Results: -------------------------- STart a 5 node cluster. Perform controller failover. During failover, the log "NO proc_initialize_msg: send failed. dest:" should not be seen. No other issue should be seen. Conditions of Submission: ------------------------- Ack from Ramesh. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel