Summary:mds : review request for [#654] Review request for Trac Ticket(s): #654 Peer Reviewer(s): Hans Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset fdb9d271c69f88dd4f815a30632fa4218851c578 Author: A V Mahesh <[email protected]> Date: Thu, 22 May 2014 10:39:33 +0530 mds: upgrade the fragment size to MDS_DIRECT_BUF_MAXSIZE [#654] Upgraded the fragment size from ~8000 (MDTM_NORMAL_MSG_FRAG_SIZE) to ~65479 (MDS_DIRECT_BUF_MAXSIZE) so that fewer message sent and the congestion risk is reduced. Removed hardcode 64000 SO_RCVBUF/SO_SNDBUF socket values, now by default setsockopt() is not set so that socket can use system wide tuning the standard way using sysctl (wmem_default/rmem_default). In case of system wide tuning sysctl has less values than MDS_DIRECT_BUF_MAXSIZE size , the default value of 65536 (fragment size) set using setsockopt(). An environment variable is provided to set rcvbuf and sndbuf to higher value where user dont want change system wide wmem_default/rmem_default ( to all application on that system), and exclusely give higher SO_RCVBUF/SO_SNDBUF Opensaf & Opensaf applcation by increaseing rmem_max/wmem_max values using sysctl. Note: ----- Increasing the fragment size has NO issue with MDS TCP in-service Upgrade , In the current code SO_RCVBUF & SO_SNDBUF of TCP sockets was already set to 64000 (MDS_SND_RCV_SIZE) using setsockopt() ,the kernel doubles this value ,and this doubled value is returned by getsockopt(). So MDS_DIRECT_BUF_MAXSIZE size is used to send for for both previous & current versions of Opensaf nodes which are using MDS TCP as transport. changeset 86105549db3daa20a28de45242b8d8ca141c50dc Author: A V Mahesh <[email protected]> Date: Thu, 22 May 2014 10:49:21 +0530 dtm: make SO_RCVBUF & SO_SNDBUF value of TCP configurable [#654] DTM to match the new fragment size ~65479 (MDS_DIRECT_BUF_MAXSIZE), removed hard-coded 64000 SO_RCVBUF/SO_SNDBUF socket values, now by default setsockopt() is not set so that socket can use system wide tuning the standard way using sysctl (wmem_default/rmem_default). In case of system wide tuning sysctl has less values than MDS_DIRECT_BUF_MAXSIZE size , the default value of 65536 (new fragment size) set using setsockopt(). An configuration variable is provided in dtmd.conf to set rcvbuf and sndbuf to higher value where user don't want change system wide wmem_default/rmem_default ( to all application on that system), and exclusively give higher SO_RCVBUF/SO_SNDBUF Opensaf Middleware by increaseing rmem_max/wmem_max values using sysctl. Complete diffstat: ------------------ osaf/libs/core/mds/include/mds_dt_tcp_disc.h | 1 - osaf/libs/core/mds/mds_dt_tcp.c | 46 ++++++++++++++++++++++++++++++++++++++++++---- osaf/libs/core/mds/mds_dt_trans.c | 14 +++++++------- osaf/services/infrastructure/dtms/config/dtmd.conf | 12 ++++++++++++ osaf/services/infrastructure/dtms/dtm/dtm_intra.c | 23 ++++++++++++----------- osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 24 +++++++++++------------- osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 34 ++++++++++++++++++++++++++++++++++ osaf/services/infrastructure/dtms/include/dtm.h | 2 ++ osaf/services/infrastructure/dtms/include/dtm_cb.h | 4 ++++ osaf/services/infrastructure/dtms/include/dtm_intra_disc.h | 2 -- 10 files changed, 124 insertions(+), 38 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- Ack from Hans Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
