Summary: v2 amfd: send node down notification during controller failover [#914]
Review request for Trac Ticket(s): #914
Peer Reviewer(s): Hans F, Hans N, Praveen
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset ff039879e1edb9f4d98a477922acbbb9444b08b2
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Fri, 23 May 2014 12:10:55 +0530
v2 amfd: send node down notification during controller failover [#914]
When
Act controller is stopped, newly act controller is not sending node oper
state disable notification. This is because of marking node oper state
disable first in avd_mds_avnd_down_evh at standby controller and then
calling avd_node_oper_state_set() from avd_node_failover. In
avd_node_oper_state_set, since oper state remain disable, the function
only
update rt attributes and donot send notification. Amf is checking
whether
node is absent and oper state is down and this way it deduces that the
failover has happened and it need to send notification.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/node.cc | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Check the ticket.
Testing, Expected Results:
--------------------------
The below notification will come:
eventType = SA_NTF_OBJECT_STATE_CHANGE
notificationObject = "safAmfNode=SC-1,safAmfCluster=myAmfCluster"
notifyingObject = "safApp=safAmfService"
notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.107 (0x6b)
additionalText = "Oper state safAmfNode=SC-1,safAmfCluster=myAmfCluster changed"
sourceIndicator = SA_NTF_OBJECT_OPERATION
State ID = SA_AMF_OP_STATE
New State: SA_AMF_OPERATIONAL_DISABLED
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
