Summary: Fix sidepstate checkpointing Review request for Trac Ticket(s): 926 Peer Reviewer(s): AMF team Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: 4.4
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset d933a1f00ffd10767e168beff9654d4abcb6bfcd Author: Hans Feldt <[email protected]> Date: Fri, 23 May 2014 13:21:08 +0200 amfd: create SI to store ckpt:ed dep_state [#926] abort in standby amfd with back trace: #0 0x00007f71264bcb35 in raise () from /lib64/libc.so.6 No symbol table info available. #1 0x00007f71264be111 in abort () from /lib64/libc.so.6 No symbol table info available. #2 0x00007f7127d51e07 in __osafassert_fail (__file=<optimized out>, __line=<optimized out>, __func=<optimized out>, __assertion=<optimized out>) at sysf_def.c:401 No locals. #3 0x00000000004103e7 in dec_si_dep_state (cb=0x69c980, dec=<optimized out>) at avd_ckpt_dec.c:2042 si_struct = 0x0 When an SI dependency is created on the active amfd it checkpoints the dep_state. When this reach the standby amfd it has not yet created the SI so it cannot store the state. The reason is the well-known race problem of standby amfd being applier. We fix this in standby amfd by creating the SI if it does not exist, this in context of the xcheck point handling. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ckpt_dec.cc | 7 +++++-- osaf/services/saf/amf/amfd/include/si.h | 1 + osaf/services/saf/amf/amfd/si.cc | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) Testing Commands: ----------------- Not tested, just built Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
