Summary: AMF: Use IMM applier in the AMF node director V3 Review request for Trac Ticket(s): #819 Peer Reviewer(s): hansf, nagu, praveen Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset ec2e17ed7dde632f421cbc6fc4ddb8461e1ffcfa Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Wed, 28 May 2014 10:50:21 +0200 AMF: Use IMM applier in the AMF node director V3 [#819] This first patch adds support for changing attributes in class SaAmfHealthcheckType Updated with review comments. Added Files: ------------ osaf/services/saf/amf/amfnd/imm.cc osaf/services/saf/amf/amfnd/include/avnd_imm.h Complete diffstat: ------------------ osaf/libs/common/amf/include/amf_defs.h | 6 + osaf/services/saf/amf/amfnd/Makefile.am | 1 + osaf/services/saf/amf/amfnd/evt.cc | 7 + osaf/services/saf/amf/amfnd/hcdb.cc | 150 +++++++++++++ osaf/services/saf/amf/amfnd/imm.cc | 758 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/services/saf/amf/amfnd/include/Makefile.am | 1 + osaf/services/saf/amf/amfnd/include/avnd.h | 1 + osaf/services/saf/amf/amfnd/include/avnd_evt.h | 8 + osaf/services/saf/amf/amfnd/include/avnd_hc.h | 1 + osaf/services/saf/amf/amfnd/include/avnd_imm.h | 148 +++++++++++++ osaf/services/saf/amf/amfnd/main.cc | 10 +- 11 files changed, 1090 insertions(+), 1 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Time is money. Stop wasting it! Get your web API in 5 minutes. www.restlet.com/download http://p.sf.net/sfu/restlet _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel