Summary: amfd : update dependent dep_state if fail-over of dependent fails
[#692]
Review request for Trac Ticket(s): #692
Peer Reviewer(s):AMF developers
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 1fcbd78f7f373b8be7b72623b8de03666db1d6f8
Author: praveen.malv...@oracle.com
Date: Thu, 29 May 2014 15:45:10 +0530
amfd : update dependent dep_state if fail-over of dependent fails [#692]
During failover of dependent, if fault occurs in the SU receiving the
active
assignment then AMF is assigning only some SIs and SG remains unstable.
AMF performs failover of failed active SU1, first by sending active for
sponsor SI to the standby SU2 and it updates si_dep_state of dependents
as
FAIL_OVER_UNDER_PROGRESS. After successful fail-over of sponsor when AMF
sends active for first level dependents to SU2 and iit updates second
level
dependents to FAIL_OVER_UNDER_PROGRESS. Now if SU2 faults and then AMF
deletes all the SUSIs in both the SUs. When one the SUs is enabled, AMF
screens SIs to update SI dep states of all the SIs before creating new
SUSIs. Here FAIL_OVER_UNDER_PROGRESS of some second level dependents is
not
updated which causes assignment of them before their sposnors. This
leads to
assignment of few SIs only and leads to unstable SG.
Patch updates si_dep_state from FAIL_OVER_UNDER_PROGRESS to
READY_TO_UNASSIGN if one of the sponsors is unassigned.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/si_dep.cc | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
2N model with 4 SIs with chain like SI dependency.
Tested this model with componentfailover and sufailover.
Kill any component in active SU, when standby SU is
receving active assignment for first dependent kill any component
in this SU also.
Testing, Expected Results:
--------------------------
There will fresh assignments active ans standby honoring
SI dependency
Conditions of Submission:
-------------------------
Ack from atleast one reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Time is money. Stop wasting it! Get your web API in 5 minutes.
www.restlet.com/download
http://p.sf.net/sfu/restlet
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
