Summary: amfd : use of db_template for AMF classes [#713]
Review request for Trac Ticket(s): #713
Peer Reviewer(s): AMF developers
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset c9da5743acb28d94a886972bc080c9c927c118cb
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:03 +0530
amfd : use db_template in AVD_SVC_TYPE_CS_TYPE [#713]
changeset bc76e042eb8ef9dbf4156723e404c2b2c319424b
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:03 +0530
amfd : use db_template in AVD_SVC_TYPE [#713]
changeset e3c6dfe78fdaf045c16243882810d016a24de972
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:04 +0530
amfd : use db_template in avd_cstype_t [#713]
changeset 5b56bd2c0a5fc08cb5a9767035c9070c63b69a52
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:04 +0530
amfd : use db_template in AVD_CTCS_TYPE [#713]
changeset 379a08e04826a7d5d909adf2efcb97ce233363f8
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:04 +0530
amfd : use db_template in AVD_CSI [#713]
changeset d8dcab4a4cf0e010e3ac3f14bcc123b5fa9a2cf2
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:04 +0530
amfd : use db_template in AVD_COMP_TYPE [#713]
changeset 7476d475304882d93d003f19f6789ff6c0e21e59
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:04 +0530
amfd : use db_template in AVD_COMPCS_TYPE [#713]
changeset ec3ec68c77bf9a94689c7846999808a8c37f2ff0
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:05 +0530
amfd : use db_template in AVD_SG [#713]
changeset e55157be39d3282b81a30cd5ab2dc142c629962f
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:05 +0530
amfd : use db_template in avd_sutype [#713]
changeset ab97b158919c3687c8c3e0a0f42065655ee930dc
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:05 +0530
amfd : use db_template in AVD_SUTCOMP_TYPE [#713]
changeset c70473b751e8f722f074c007cd84738f14919cfc
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:05 +0530
amfd : use db_template in AVD_AMF_SG_TYPE [#713]
changeset 41cf3030edebdbb9921327948711373f001c18f8
Author: praveen.malv...@oracle.com
Date: Wed, 04 Jun 2014 15:45:05 +0530
amfd : use db_template in AVD_COMP [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/apptype.cc | 2 +-
osaf/services/saf/amf/amfd/ckpt_dec.cc | 24 +++++++++---------
osaf/services/saf/amf/amfd/ckpt_enc.cc | 52
+++++++++++++++--------------------------
osaf/services/saf/amf/amfd/ckpt_updt.cc | 30 ++++++++++++------------
osaf/services/saf/amf/amfd/cluster.cc | 11 ++------
osaf/services/saf/amf/amfd/comp.cc | 60
++++++++++++++----------------------------------
osaf/services/saf/amf/amfd/compcstype.cc | 71
++++++++++++++++-----------------------------------------
osaf/services/saf/amf/amfd/comptype.cc | 33
+++++---------------------
osaf/services/saf/amf/amfd/csi.cc | 50
+++++++++++++--------------------------
osaf/services/saf/amf/amfd/csiattr.cc | 12 ++++----
osaf/services/saf/amf/amfd/cstype.cc | 35
++++-----------------------
osaf/services/saf/amf/amfd/ctcstype.cc | 37
+++++++----------------------
osaf/services/saf/amf/amfd/hlt.cc | 4 +-
osaf/services/saf/amf/amfd/imm.cc | 18 +++++--------
osaf/services/saf/amf/amfd/include/comp.h | 13 +++++----
osaf/services/saf/amf/amfd/include/csi.h | 5 ++-
osaf/services/saf/amf/amfd/include/sg.h | 6 ++--
osaf/services/saf/amf/amfd/include/sgtype.h | 4 +-
osaf/services/saf/amf/amfd/include/si.h | 6 +---
osaf/services/saf/amf/amfd/include/sutcomptype.h | 3 +-
osaf/services/saf/amf/amfd/include/sutype.h | 9 +------
osaf/services/saf/amf/amfd/ndproc.cc | 4 +-
osaf/services/saf/amf/amfd/pg.cc | 2 +-
osaf/services/saf/amf/amfd/role.cc | 7 ++---
osaf/services/saf/amf/amfd/sg.cc | 65
++++++++++++++--------------------------------------
osaf/services/saf/amf/amfd/sgproc.cc | 16 ++++++------
osaf/services/saf/amf/amfd/sgtype.cc | 34
+++++++--------------------
osaf/services/saf/amf/amfd/si.cc | 11 +++-----
osaf/services/saf/amf/amfd/su.cc | 14 +++++-----
osaf/services/saf/amf/amfd/sutcomptype.cc | 29 ++++------------------
osaf/services/saf/amf/amfd/sutype.cc | 38
+++++++-----------------------
osaf/services/saf/amf/amfd/svctype.cc | 27 ++++-----------------
osaf/services/saf/amf/amfd/svctypecstypes.cc | 40
++++++++-----------------------
osaf/services/saf/amf/amfd/util.cc | 22 ++++++++---------
34 files changed, 255 insertions(+), 539 deletions(-)
Testing Commands:
-----------------
Brought one controller up.
Testing, Expected Results:
--------------------------
came up successfulyr.
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
