Iam unable to imagine what's the problem with polling by other means? I mean, applications would still have to poll for this proposed notification!
I am not sure if a notification that is sent when "AMF is ready" can be treated as equivalent to "Standby Controller being ready"! (Not sure if you really meant that to be literally) I think introduction of a notification such as this would be appropriate when/if we are building a "deployable solution"(using the notification) in OpenSAF or for the OpenSAF integrator. What we could alternatively consider, is to make AMF report to NID only after it is ready(you would remember glowing of an LED). This way the test applications too can wait for the status of OpenSAF startup. Cheers, Mathi. >-----Original Message----- >From: Hans Feldt [mailto:hans.fe...@ericsson.com] >Sent: Wednesday, June 04, 2014 10:45 AM >To: Mathivanan Naickan Palanivelu >Cc: opensaf-devel@lists.sourceforge.net >Subject: RE: [devel] [PATCH 0 of 1] Review Request for v2 amfd: Send >notifications when cold sync is completed [#860] > >As it says in the ticket. Mainly for test to know when the standby controller >is >ready. I think SMF has some similar problem when it rolls over nodes and >needs to be poll. >Thanks, >Hans > >> -----Original Message----- >> From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] >> Sent: den 3 juni 2014 21:03 >> To: Minh Chau H; Hans Feldt; Hans Nordebäck; Nagendra Kumar; Praveen >> Malviya >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: RE: [devel] [PATCH 0 of 1] Review Request for v2 amfd: Send >> notifications when cold sync is completed [#860] >> >> Hi, >> >> Just curious, how would this notification be useful to the end-user? I >> mean, is there an usecase where this notification would be consumed by >the end-user? >> (Or is it just for testing purposes? If so, I think just logging would >> be enough!) >> >> Thanks, >> Mathi. >> >> >-----Original Message----- >> >From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] >> >Sent: Tuesday, June 03, 2014 10:58 AM >> >To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra >> >Kumar; Praveen Malviya >> >Cc: opensaf-devel@lists.sourceforge.net >> >Subject: [devel] [PATCH 0 of 1] Review Request for v2 amfd: Send >> >notifications when cold sync is completed [#860] >> > >> >Summary: amfd: Send notifications when cold sync is completed [#860] >> >Review request for Trac Ticket(s): 860 Peer Reviewer(s): Hans F, Hans >> >N, Nagendra, Praveen Pull request to: >> >Affected branch(es): default >> >Development branch: default >> > >> >-------------------------------- >> >Impacted area Impact y/n >> >-------------------------------- >> > Docs n >> > Build system n >> > RPM/packaging n >> > Configuration files n >> > Startup scripts n >> > SAF services y >> > OpenSAF services n >> > Core libraries n >> > Samples n >> > Tests n >> > Other n >> > >> > >> >Comments (indicate scope for each "y" above): >> >--------------------------------------------- >> >This is V2 >> > >> >changeset 30dbc07ea849af8a24530414fe82e838a0e6fb68 >> >Author: Minh Hon Chau <minh.c...@dektech.com.au> >> >Date: Tue, 03 Jun 2014 15:08:52 +1000 >> > >> > amfd: Send notification when cold sync is completed [#860] >> > >> > This is enhancement that standby amfd sends notification when the >> >cold sync >> > is completed. >> > >> > The fact that we can't add a new AMF state change notification under >> >SAF >> > vendor, but we can defines this cold sync as state change >> >notification under >> > OpenSAF vendor. >> > >> > The patch adds new OpenSaf vendor Id, and new cold sync state >change >> > function to be called where the cold sync is completed. >> > >> > >> >Complete diffstat: >> >------------------ >> > osaf/services/saf/amf/amfd/chkop.cc | 1 + >> > osaf/services/saf/amf/amfd/include/ntf.h | 14 ++++++++++++-- >> > osaf/services/saf/amf/amfd/ntf.cc | 54 >> >+++++++++++++++++++++++++++++++++++++++++++++++++++--- >> > 3 files changed, 64 insertions(+), 5 deletions(-) >> > >> > >> >Testing Commands: >> >----------------- >> >- Run "ntfsubscribe -s &" on standby sc >> >- Reboot active sc >> > >> > >> >Testing, Expected Results: >> >-------------------------- >> >- "Cold sync <node dn> completed" notification pops up in >> >ntfsubscribe printout >> > >> > >> >Conditions of Submission: >> >------------------------- >> > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> >> > >> > >> >Arch Built Started Linux distro >> >------------------------------------------- >> >mips n n >> >mips64 n n >> >x86 n n >> >x86_64 y n >> >powerpc n n >> >powerpc64 n n >> > >> > >> >Reviewer Checklist: >> >------------------- >> >[Submitters: make sure that your review doesn't trigger any >> >checkmarks!] >> > >> > >> >Your checkin has not passed review because (see checked entries): >> > >> >___ Your RR template is generally incomplete; it has too many blank >entries >> > that need proper data filled in. >> > >> >___ You have failed to nominate the proper persons for review and push. >> > >> >___ Your patches do not have proper short+long header >> > >> >___ You have grammar/spelling in your header that is unacceptable. >> > >> >___ You have exceeded a sensible line length in your >> >headers/comments/text. >> > >> >___ You have failed to put in a proper Trac Ticket # into your commits. >> > >> >___ You have incorrectly put/left internal data in your comments/files >> > (i.e. internal bug tracking tool IDs, product names etc) >> > >> >___ You have not given any evidence of testing beyond basic build tests. >> > Demonstrate some level of runtime or other sanity testing. >> > >> >___ You have ^M present in some of your files. These have to be >removed. >> > >> >___ You have needlessly changed whitespace or added whitespace crimes >> > like trailing spaces, or spaces before tabs. >> > >> >___ You have mixed real technical changes with whitespace and other >> > cosmetic code cleanup changes. These have to be separate commits. >> > >> >___ You need to refactor your submission into logical chunks; there is >> > too much content into a single commit. >> > >> >___ You have extraneous garbage in your review (merge commits etc) >> > >> >___ You have giant attachments which should never have been sent; >> > Instead you should place your content in a public tree to be pulled. >> > >> >___ You have too many commits attached to an e-mail; resend as threaded >> > commits, or place in a public tree for a pull. >> > >> >___ You have resent this content multiple times without a clear indication >> > of what has changed between each re-send. >> > >> >___ You have failed to adequately and individually address all of the >> > comments and change requests that were proposed in the initial review. >> > >> >___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> > >> >___ Your computer have a badly configured date and time; confusing the >> > the threaded patch review. >> > >> >___ Your changes affect IPC mechanism, and you don't present any results >> > for in-service upgradability test. >> > >> >___ Your changes affect user manual and documentation, your patch >series >> > do not contain the patch that updates the Doxygen manual. >> > >> > >> >--------------------------------------------------------------------- >> >--------- Learn Graph Databases - Download FREE O'Reilly Book "Graph >> >Databases" is the definitive new guide to graph databases and their >> >applications. Written by three acclaimed leaders in the field, this >> >first edition is now available. >> >Download your free book today! >> >http://p.sf.net/sfu/NeoTech >> >_______________________________________________ >> >Opensaf-devel mailing list >> >Opensaf-devel@lists.sourceforge.net >> >https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
