Summary: Extended Name Type [#191]
Review request for Trac Ticket(s): 191
Peer Reviewer(s): Mathi
Pull request to:
Affected branch(es): default(4.5)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs y
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
These patches add new AIS API functions and definitions for the extended
SaNameT format, used to tunnel NUL-terminated strings through SaNameT.
They also add support library functions to be used in agent libraries.
Changes from previous review:
* Fixed an off-by-one bug i saAisNameBorrow()
* Fixed RPM build problem
* Implemented review comment that the saAisNameLend and saAisBorrow shall
be available in all SAF libraries, instead of just in libSaImmOm
changeset a836344c6a36ad87cc5ad3e79da0499830733171
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 09 Jun 2014 12:48:23 +0200
osaf: Add declarations of saAisNameLend() and saAisNameBorrow() [#191]
Add declarations of saAisNameLend() and saAisNameBorrow() to
saAis_B_5_14.h.
Update 00-README.conf with description of how to enable the extended
SaNameT
type.
changeset 5db6d88a050849e6ce6d5b33ca48bd3b5ce8a06a
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 09 Jun 2014 12:50:15 +0200
osaf: Add library functions for handling the extended SaNameT format
[#191]
Add support library functions that make it easier for agent libraries to
handle the extended SaNameT format in old SAF APIs that use the SaNameT
type.
changeset 688d74727b89a6ea770dbf199befe5af81fa11ab
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 09 Jun 2014 12:50:17 +0200
osaf: Add implementations of saAisNameLend() and saAisNameBorrow()
[#191]
The functions saAisNameLend() and saAisNameBorrow() are defined in
saAis_B_5_14.h, but there is no libSaAis library. Therefore, these two
functions are put in all SAF libraries as weak aliases, so that an
application can resolve the symbols no matter what SAF libraries it is
linked against.
Complete diffstat:
------------------
00-README.conf | 18 +++++++++++
configure.ac | 1 +
osaf/libs/common/Makefile.am | 2 +-
osaf/libs/common/ais/Makefile.am | 27 ++++++++++++++++
osaf/libs/common/ais/aisa_api.c | 140
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/core/common/Makefile.am | 1 +
osaf/libs/core/common/include/Makefile.am | 1 +
osaf/libs/core/common/include/osaf_extended_name.h | 232
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/core/common/osaf_extended_name.c | 184
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/libs/core/leap/sysf_def.c | 3 +
osaf/libs/saf/include/saAis.h | 4 ++
osaf/libs/saf/include/saAis_B_5_14.h | 17 ++++++++++
osaf/libs/saf/libSaAmf/Makefile.am | 1 +
osaf/libs/saf/libSaAmf/libSaAmf.map | 1 +
osaf/libs/saf/libSaCkpt/Makefile.am | 1 +
osaf/libs/saf/libSaCkpt/libSaCkpt.map | 1 +
osaf/libs/saf/libSaClm/Makefile.am | 1 +
osaf/libs/saf/libSaClm/libSaClm.map | 1 +
osaf/libs/saf/libSaEvt/Makefile.am | 1 +
osaf/libs/saf/libSaEvt/libSaEvt.map | 1 +
osaf/libs/saf/libSaImm/Makefile.am | 2 +
osaf/libs/saf/libSaImm/libSaImmOi.map | 1 +
osaf/libs/saf/libSaImm/libSaImmOm.map | 1 +
osaf/libs/saf/libSaLck/Makefile.am | 1 +
osaf/libs/saf/libSaLck/libSaLck.map | 1 +
osaf/libs/saf/libSaLog/Makefile.am | 1 +
osaf/libs/saf/libSaLog/libSaLog.map | 1 +
osaf/libs/saf/libSaMsg/Makefile.am | 1 +
osaf/libs/saf/libSaMsg/libSaMsg.map | 1 +
osaf/libs/saf/libSaNtf/Makefile.am | 1 +
osaf/libs/saf/libSaNtf/libSaNtf.map | 1 +
osaf/libs/saf/libSaPlm/Makefile.am | 1 +
osaf/libs/saf/libSaPlm/libSaPlm.map | 1 +
osaf/libs/saf/libSaSmf/Makefile.am | 1 +
osaf/libs/saf/libSaSmf/libSaSmf.map | 1 +
35 files changed, 653 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Build and start OpenSAF.
Testing, Expected Results:
--------------------------
OpenSAF should build and start successfully.
Conditions of Submission:
-------------------------
Ack from Mathi.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://www.hpccsystems.com
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
