Hi AndersBj, Reviewed and tested the patch. Ack with minor comments.
Comments: 1. OpensafImm.xml name may be changed like OpensafImm_UPgrade_4.5.xml 2. IMM README must be updated, regarding opensafLongDnsAllowed . /Neel. On Monday 09 June 2014 11:47 AM, Anders Bjornerstedt wrote: > Summary: IMM: Add config attribute 'd' to class 'OpensafImm' [#897] > Review request for Trac Ticket(s): 897 > Peer Reviewer(s): Neel; Zoran > Pull request to: > Affected branch(es): default(4.5) > Development branch: > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 83fa169f43de5cb6b7fb70048bffc68f7fa4c390 > Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com> > Date: Thu, 05 Jun 2014 14:55:19 +0200 > > IMM: Add config attribute 'opensafLongDnsAllowed' to class 'OpensafImm' > [#897] > > A config attribute named 'opensafLongDnsAllowed' is added to the class > 'OpensafImm'. The default value is 0 with the intended meaning that > long DNs > are not allowed. Any other value has the meaning that long DNs are > allowed. > A boolean function 'getLongDnsAllowed()' has been added to ImmModel. > This > function will be used by the function ImmModel::ccbObjectCreate() when > it > detects that an object proposed to be created has a DN longer than 255 > bytes. The creation will only be allowed if getLongDnsAllowed() returns > true. > > Validation of updates to the value of 'opensafLongDnsAllowed' will be > added > as part of ticket #934. Transitioning from true to false will only be > allowed if the imm database currently has no object with a long DN. > > An imm xml file containing the extended class definition for OpensafImm > has > been added at samples/immsv/OpensafImm.xml The xml file should be used > for > upgrading the class when older OpenSAF systems are upgraded to OpenSAF > 4.5. > > > Added Files: > ------------ > samples/immsv/OpensafImm.xml > > > Complete diffstat: > ------------------ > osaf/libs/common/immsv/include/immsv_api.h | 2 ++ > osaf/services/saf/immsv/immloadd/imm_loader.cc | 10 ++++++++-- > osaf/services/saf/immsv/immnd/ImmModel.cc | 24 > ++++++++++++++++++++++++ > osaf/services/saf/immsv/immnd/ImmModel.hh | 1 + > samples/immsv/OpensafImm.xml | 64 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 99 insertions(+), 2 deletions(-) > > > Testing Commands: > ----------------- > Nothing much except the existence of the new attribute can be "tested" > currently since the functionality that the attribute is intended for > has not yet been added. Support for long DNs in the IMM is tracked by > ticket #886 'IMM: Add support for long DNs in existing IMM APIs' > > it should be possible to test upgrading the class on older systems > via 'immcfg -f samples/immsv/OpensafImm.xml'. Note that the flag > for allowing schema chanes then needs to be set to on. > > Testing, Expected Results: > -------------------------- > This review is mainly concerned with establishing consensus on > the naming and mechanism for allowing long DNs on a per-site > basis. > > > Conditions of Submission: > ------------------------- > Ack from Neel and Zoran. > > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
