Summary: Start of SG refactoring v2
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF developers
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This a starting point of changing struct SG to an abstract class which is
specialized into redundancy model specific classes. The intention with this
is to simlify logic in the current fsm code where today most of the comlexity
is. This fist patches will be followed by other to remove all functions
pointers changing them to methods and then cleanup of the fsm code.
changeset ea37b5c651e813adc64c0b084848608569e24541
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 16 Jun 2014 07:01:31 +0200
amfd: change struct AVD_SG to class [#713]
changeset 5b15cc813561eb6ba9930071d67f8adfa77d2201
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 16 Jun 2014 07:02:06 +0200
amfd: add specialized red model specific SG classes [#713]
A first step in converting the C based SG FSM files into C++. The idea
with
that is to simplify the FSM code.
changeset ae4bf4e3630f5973f297af6f4844d643741dffc9
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 16 Jun 2014 07:02:35 +0200
amfd: change SG node_fail function ptr to method [#713]
changeset 1fa0845a7075d77c60761ebb7885d4eabbea0089
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 16 Jun 2014 07:02:49 +0200
amfd: change SG realign function ptr to method [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 ++--
osaf/services/saf/amf/amfd/include/app.h | 6 +++---
osaf/services/saf/amf/amfd/include/csi.h | 2 +-
osaf/services/saf/amf/amfd/include/sg.h | 101
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------
osaf/services/saf/amf/amfd/include/sgtype.h | 8 ++++----
osaf/services/saf/amf/amfd/include/si.h | 2 +-
osaf/services/saf/amf/amfd/include/si_dep.h | 2 +-
osaf/services/saf/amf/amfd/include/su.h | 7 ++++---
osaf/services/saf/amf/amfd/sg.cc | 80
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 54
+++++++-----------------------------------------------
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 53
++++++-----------------------------------------------
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 53
++++++-----------------------------------------------
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 47
++++++-----------------------------------------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 53
++++++-----------------------------------------------
14 files changed, 193 insertions(+), 279 deletions(-)
Testing Commands:
-----------------
Start uml cluster
Testing, Expected Results:
--------------------------
Starts
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
