Summary: AMF notification related enhancements {#106]
Review request for Trac Ticket(s): #106
Peer Reviewer(s): AMF contributors
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):Default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 5b6b3a3b88f5f385b340b5f637222f337599f09e
Author: [email protected]
Date: Mon, 23 Jun 2014 17:38:24 +0530
amfd : send old state of AMF entities in notifications [#106]
Now AMF includes old state also while generating notifications for
change in
admin state, operational state, presence state, HA state and assignment
state of applicable AMF entities.
See #106 for sample notifications.
changeset 5e436e662c2ee99f2b79f8fcaeb12bafb1b2567b
Author: [email protected]
Date: Mon, 23 Jun 2014 17:39:05 +0530
amfd : send error report and clear notifications [#106] Error report and
error clear are miscellaneous types of notifications. At present
Notification Service does not support
saNtfMiscellaneousNotificationAllocate(). So in this enhancement, alarms
will be sent and cleared whenever AMF reports error and clear error on
component respectively.
See #106 for sample error report and error clear notification.
changeset 283a9c8ab48706112a7dc0576872cb7e81050dc0
Author: [email protected]
Date: Mon, 23 Jun 2014 17:39:31 +0530
amfnd : inform AMFD to send error report notification [#106]
changeset 854eae8b7dd384cc4f0ea3c604816f3929baa507
Author: [email protected]
Date: Mon, 23 Jun 2014 17:40:12 +0530
amfnd : inform AMFD to send error clear notification [#106]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/include/ntf.h | 3 +
osaf/services/saf/amf/amfd/include/util.h | 1 +
osaf/services/saf/amf/amfd/ndproc.cc | 13 +++++++
osaf/services/saf/amf/amfd/ntf.cc | 98
++++++++++++++++++++++++++++++++++++++++++++--------------
osaf/services/saf/amf/amfd/util.cc | 13 +++++++
osaf/services/saf/amf/amfnd/amfnd.cc | 16 +++++++++
osaf/services/saf/amf/amfnd/comp.cc | 10 ++++++
osaf/services/saf/amf/amfnd/err.cc | 12 +++++++
osaf/services/saf/amf/amfnd/include/avnd_comp.h | 1 +
9 files changed, 143 insertions(+), 24 deletions(-)
Testing Commands:
-----------------
Sample notifications are posted in the ticket #106 after testing
Testing, Expected Results:
--------------------------
Sample notifications are posted in the ticket #106 after testing
Conditions of Submission:
-------------------------
Ack from atleast onre reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
