Summary: osaf: port existing daemonization and nid process to systemd "new-style" daemon Review request for Trac Ticket(s): 455 Peer Reviewer(s): AndersW, Mathi Pull request to: Mathi Affected branch(es): default Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs y Build system n RPM/packaging n Configuration files n Startup scripts y SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch is an addition to the previously submitted patch for this bug. It incorporates reviewer comments including adding "remote-fs" and "local-fs" dependencies, and some commentary in the README file on how to start OpenSAF under systemd. changeset 46c9c8d099601f851d1aecbaeabde3164c60690e Author: Alex Jones <ajo...@genband.com> Date: Mon, 07 Jul 2014 11:28:10 -0400 osaf: port existing daemonization and nid process to systemd "new-style" daemon [#455] Jun 2 16:55:57 linux-po6q osafrded[16114]: Started Jun 2 16:55:57 linux-po6q osafrded[16114]: Creation of real-time thread 'OSAF_TMR' FAILED - 'Operation not permitted' Jun 2 16:55:57 linux-po6q osafrded[16114]: ER ncs_core_agents_startup FAILED Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Failed Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Going for recovery Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Trying To RESPAWN /usr/lib64/opensaf/clc-cli/osaf-rded attempt #1 Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Sending SIGKILL to RDE, pid=16106 Jun 2 16:55:57 linux- po6q osafrded[16114]: Exiting... Jun 2 16:56:12 linux-po6q osafrded[16133]: Started Linux distros that use a version of systemd < 205 (OpenSUSE 12.1, OpenSUSE 12.2, Fedora <= 19), fail to start opensafd because, by default, these versions of systemd do not assign any RT time budgets to the "cpu" cgroups for services. The solution is in two parts: (1) Create an opensafd.service file for use by systemd which has cgroup info in it. This cgroup info is not put into the service file if the systemd version is >= 205. (2) Make plmcd a full systemd-enabled daemon. Complete diffstat: ------------------ README | 11 +++++++++++ contrib/plmc/config/plmcboot.service.in | 2 +- contrib/plmc/config/plmcd.service.in | 2 +- osaf/services/infrastructure/nid/config/opensafd.service.in | 2 +- 4 files changed, 14 insertions(+), 3 deletions(-) Testing Commands: ----------------- systemctl start opensafd.service systemctl start plmcd.service Testing, Expected Results: -------------------------- OpenSAF succesfully starts under systemd. Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y OpenSUSE 12.2, Fedora 19 powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel